Skip all dotnet-watch tests on non-Windows platforms #49336
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR updates the test suite to skip additional tests on Unix systems due to a known issue.
- Adds a skip attribute to the HostRestart test in RuntimeProcessLauncherTests.cs.
- Adds a skip attribute to the AutoRestartOnRudeEditAfterRestartPrompt test in ApplyDeltaTests.cs.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| test/dotnet-watch.Tests/HotReload/RuntimeProcessLauncherTests.cs | Adds a skip attribute to bypass the HostRestart test on Unix platforms. |
| test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs | Adds a skip attribute to bypass the AutoRestartOnRudeEditAfterRestartPrompt test on Unix platforms. |
Comments suppressed due to low confidence (2)
test/dotnet-watch.Tests/HotReload/RuntimeProcessLauncherTests.cs:399
- Consider adding an inline comment or a TODO note above the skip attribute detailing when this skip can be removed (e.g., once the referenced issue is resolved) to enhance clarity for future maintainers.
[SkipOnPlatform(TestPlatforms.AnyUnix, "https://github.com/dotnet/sdk/issues/49307")]
test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs:109
- Consider adding an inline comment or a TODO note above the skip attribute to indicate when this skip may be revisited, ensuring clarity on the temporary nature of this workaround.
[SkipOnPlatform(TestPlatforms.AnyUnix, "https://github.com/dotnet/sdk/issues/49307")]
This was referenced Jun 11, 2025
Open
|
Superseded by #49357 |
MiYanni
approved these changes
Jun 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.