Skip to content

Skip failing dotnet-watch tests #49357

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 12, 2025
Merged

Skip failing dotnet-watch tests #49357

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f8a63ac
Skip failing dotnet-watch tests
Jun 11, 2025
fc8f9a0
Continue skipping failed dotnet-watch tests
Jun 11, 2025
ea4a638
Continue skipping failed dotnet-watch tests
Jun 11, 2025
d4858c8
Continue to skip
Jun 12, 2025
2edec69
Continue to skip
Jun 12, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 5 additions & 5 deletions test/dotnet-watch.Tests/HotReload/ApplyDeltaTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,7 +105,7 @@ public async Task AutoRestartOnRudeEdit(bool nonInteractive)
App.AssertOutputContains($"[WatchHotReloadApp ({ToolsetInfo.CurrentTargetFramework})] Launched");
}

[Fact]
[Fact(Skip = "https://github.com/dotnet/sdk/issues/49307")]
public async Task AutoRestartOnRudeEditAfterRestartPrompt()
{
var testAsset = TestAssets.CopyTestAsset("WatchHotReloadApp")
Expand Down Expand Up @@ -146,7 +146,7 @@ public async Task AutoRestartOnRudeEditAfterRestartPrompt()
App.AssertOutputContains($"[WatchHotReloadApp ({ToolsetInfo.CurrentTargetFramework})] Launched");
}

[Theory]
[Theory(Skip = "https://github.com/dotnet/sdk/issues/49307")]
[CombinatorialData]
public async Task AutoRestartOnNoEffectEdit(bool nonInteractive)
{
Expand Down Expand Up @@ -215,7 +215,7 @@ public async Task BaselineCompilationError()
/// We currently do not support applying project changes.
/// The workaround is to restart via Ctrl+R.
/// </summary>
[Fact]
[Fact(Skip = "https://github.com/dotnet/sdk/issues/49307")]
public async Task ProjectChangeAndRestart()
{
var testAsset = TestAssets.CopyTestAsset("WatchNoDepsApp")
Expand Down Expand Up @@ -269,7 +269,7 @@ public async Task ChangeFileInFSharpProject()
await App.AssertOutputLineStartsWith("<Updated>");
}

[Fact]
[Fact(Skip = "https://github.com/dotnet/sdk/issues/49307")]
public async Task ChangeFileInFSharpProjectWithLoop()
{
var testAsset = TestAssets.CopyTestAsset("FSharpTestAppSimple")
Expand Down Expand Up @@ -757,7 +757,7 @@ public static void PrintDirectoryName([CallerFilePathAttribute] string filePath
await App.AssertOutputLineStartsWith("> NewSubdir");
}

[Fact]
[Fact(Skip = "https://github.com/dotnet/sdk/issues/49307")]
public async Task Aspire()
{
var tfm = ToolsetInfo.CurrentTargetFramework;
Expand Down
8 changes: 4 additions & 4 deletions test/dotnet-watch.Tests/HotReload/RuntimeProcessLauncherTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ private RunningWatcher StartWatcher(TestAsset testAsset, string[] args, string w
return new RunningWatcher(this, watcher, watchTask, reporter, console, serviceHolder, shutdownSource);
}

[Theory]
[Theory(Skip = "https://github.com/dotnet/sdk/issues/49307")]
[CombinatorialData]
public async Task UpdateAndRudeEdit(TriggerEvent trigger)
{
Expand Down Expand Up @@ -295,7 +295,7 @@ async Task MakeRudeEditChange()
}
}

[Theory]
[Theory(Skip = "https://github.com/dotnet/sdk/issues/49307")]
[CombinatorialData]
public async Task UpdateAppliedToNewProcesses(bool sharedOutput)
{
Expand Down Expand Up @@ -394,7 +394,7 @@ public enum UpdateLocation
TopFunction,
}

[Theory]
[Theory(Skip = "https://github.com/dotnet/sdk/issues/49307")]
[CombinatorialData]
public async Task HostRestart(UpdateLocation updateLocation)
{
Expand Down Expand Up @@ -485,7 +485,7 @@ public static void Print()
await hasUpdate.WaitAsync(w.ShutdownSource.Token);
}

[Fact]
[Fact(Skip = "https://github.com/dotnet/sdk/issues/49307")]
public async Task RudeEditInProjectWithoutRunningProcess()
{
var testAsset = CopyTestAsset("WatchAppMultiProc");
Expand Down
Loading