Fix launch profile test failure #48713
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some failed RazorSdk tests are unrelated to the current changes. The failed RazorSdk tests were fixed in #48715. |
There was a problem hiding this comment.
Pull Request Overview
This PR fixes a test failure caused by unwanted launch settings output during dotnet run execution. Key changes include:
- Removal of the Skip attribute from the failing test.
- Addition of the "--verbosity quiet" argument to suppress stdout output during test execution.
Comments suppressed due to low confidence (2)
test/dotnet.Tests/CommandTests/Run/GivenDotnetRunBuildsCsProj.cs:412
- [nitpick] With the removal of the Skip attribute, please ensure that this test now passes reliably across different environments. Consider adding specific assertions to verify that launch settings messages are successfully suppressed.
[Fact]
test/dotnet.Tests/CommandTests/Run/GivenDotnetRunBuildsCsProj.cs:422
- [nitpick] Double-check that the addition of '--verbosity quiet' correctly suppresses only the launch settings messages and does not hide crucial error output in other scenarios.
var cmd = new DotnetCommand(Log, "run", "--verbosity", "quiet")
…ix-launch-profile-test
marcpopMSFT
approved these changes
Apr 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #42841
This change works around #45640, where dotnet run writes launch settings messages to stdout.
We suppress the output using --verbosity quiet to avoid test failures.