[Blazor] Fix scoped CSS hot reload #42137
Merged
+10
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for your PR, @MackinnonBuck. |
MackinnonBuck
commented
Jul 12, 2024
| internal static string ComputeIntegrity(string identity, string originalItemSpec) | ||
| { | ||
| var file = File.Exists(identity) ? | ||
| using var file = File.Exists(identity) ? |
There was a problem hiding this comment.
@javiercn When using the locally-built SDK, I wasn't able to reproduce the issue where the file was left in use between hot reload edits. But I've gone ahead and made this change anyway in case it was the culprit.
There was a problem hiding this comment.
I also confirmed that we do take this code path when making CSS changes:
Which means that this extra
using theoretically shouldn't make a difference.
But it could have been that for some reason this path was being taken earlier, when I observed that hot reload was breaking. And now that the other code path is taken, everything works.
05ce838 to
87e4aef
Compare
3 tasks
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
javiercn
approved these changes
Jul 15, 2024
3 tasks
|
/azp run |
|
Azure Pipelines successfully started running 4 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes an issue where the CSS bundle wasn't getting regenerated when a change to a CSS file was made during a
dotnet watchsession.Fixes https://github.com/dotnet/AspNetCore-ManualTests/issues/2776