-
Notifications
You must be signed in to change notification settings - Fork 5.1k
[main] Source code updates from dotnet/dotnet #117845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Source code updates from dotnet/dotnet #117845
Conversation
Updated Dependencies: System.CommandLine (Version 2.0.0-beta7.25367.101 -> 2.0.0-beta7.25368.102) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25367.101 -> 0.11.5-alpha.25368.102) Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport, Microsoft.DotNet.ApiCompat.Task (Version 10.0.100-preview.7.25367.101 -> 10.0.100-preview.7.25368.102) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.XUnitExtensions, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.PackageTesting (Version 10.0.0-beta.25367.101 -> 10.0.0-beta.25368.102) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25367.101 -> 2.9.3-beta.25368.102) Microsoft.NETCore.App.Ref, runtime.native.System.IO.Ports, Microsoft.NETCore.ILAsm, Microsoft.NET.Sdk.IL, System.Text.Json, System.Reflection.Metadata, System.Reflection.MetadataLoadContext (Version 10.0.0-preview.7.25367.101 -> 10.0.0-preview.7.25368.102) Microsoft.Net.Compilers.Toolset, Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-2.25367.101 -> 5.0.0-2.25368.102) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25367.101 -> 10.0.0-preview.25368.102)
Updated Dependencies: System.CommandLine (Version 2.0.0-beta7.25368.102 -> 2.0.0-beta7.25368.105) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25368.102 -> 0.11.5-alpha.25368.105) Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport, Microsoft.DotNet.ApiCompat.Task (Version 10.0.100-preview.7.25368.102 -> 10.0.100-preview.7.25368.105) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.XUnitExtensions, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.PackageTesting (Version 10.0.0-beta.25368.102 -> 10.0.0-beta.25368.105) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25368.102 -> 2.9.3-beta.25368.105) Microsoft.NETCore.App.Ref, runtime.native.System.IO.Ports, Microsoft.NETCore.ILAsm, Microsoft.NET.Sdk.IL, System.Text.Json, System.Reflection.Metadata, System.Reflection.MetadataLoadContext (Version 10.0.0-preview.7.25368.102 -> 10.0.0-preview.7.25368.105) Microsoft.Net.Compilers.Toolset, Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.CSharp, Microsoft.CodeAnalysis.Analyzers (Version 5.0.0-2.25368.102 -> 5.0.0-2.25368.105) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25368.102 -> 10.0.0-preview.25368.105)
Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25368.105 -> 5.0.0-2.25372.103) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25368.105 -> 10.0.0-preview.25372.103) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-preview.7.25368.105 -> 10.0.100-preview.7.25372.103) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25368.105 -> 10.0.0-beta.25372.103) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25368.105 -> 0.11.5-alpha.25372.103) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25368.105 -> 2.9.3-beta.25372.103) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-preview.7.25368.105 -> 10.0.0-preview.7.25372.103) System.CommandLine (Version 2.0.0-beta7.25368.105 -> 2.0.0-beta7.25372.103)
Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25372.103 -> 5.0.0-2.25373.104) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25372.103 -> 10.0.0-preview.25373.104) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-preview.7.25372.103 -> 10.0.100-preview.7.25373.104) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25372.103 -> 10.0.0-beta.25373.104) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25372.103 -> 0.11.5-alpha.25373.104) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25372.103 -> 2.9.3-beta.25373.104) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-preview.7.25372.103 -> 10.0.0-preview.7.25373.104) System.CommandLine (Version 2.0.0-beta7.25372.103 -> 2.0.0-beta7.25373.104)
Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25373.104 -> 5.0.0-2.25374.102) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25373.104 -> 10.0.0-preview.25374.102) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-preview.7.25373.104 -> 10.0.100-preview.7.25374.102) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25373.104 -> 10.0.0-beta.25374.102) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25373.104 -> 0.11.5-alpha.25374.102) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25373.104 -> 2.9.3-beta.25374.102) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-preview.7.25373.104 -> 10.0.0-preview.7.25374.102) System.CommandLine (Version 2.0.0-beta7.25373.104 -> 2.0.0-beta7.25374.102)
Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25374.102 -> 5.0.0-2.25375.106) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25374.102 -> 10.0.0-preview.25375.106) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-preview.7.25374.102 -> 10.0.100-preview.7.25375.106) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25374.102 -> 10.0.0-beta.25375.106) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25374.102 -> 0.11.5-alpha.25375.106) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25374.102 -> 2.9.3-beta.25375.106) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-preview.7.25374.102 -> 10.0.0-preview.7.25375.106) System.CommandLine (Version 2.0.0-beta7.25374.102 -> 2.0.0-rc.1.25375.106)
Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25375.106 -> 5.0.0-2.25375.119) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25375.106 -> 10.0.0-preview.25375.119) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-preview.7.25375.106 -> 10.0.100-preview.7.25375.119) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25375.106 -> 10.0.0-beta.25375.119) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25375.106 -> 0.11.5-alpha.25375.119) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25375.106 -> 2.9.3-beta.25375.119) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-preview.7.25375.106 -> 10.0.0-preview.7.25375.119) System.CommandLine (Version 2.0.0-rc.1.25375.106 -> 2.0.0-rc.1.25375.119)
Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25375.119 -> 5.0.0-2.25377.103) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25375.119 -> 10.0.0-preview.25377.103) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-preview.7.25375.119 -> 10.0.100-preview.7.25377.103) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25375.119 -> 10.0.0-beta.25377.103) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25375.119 -> 0.11.5-alpha.25377.103) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25375.119 -> 2.9.3-beta.25377.103) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-preview.7.25375.119 -> 10.0.0-preview.7.25377.103) System.CommandLine (Version 2.0.0-rc.1.25375.119 -> 2.0.0-rc.1.25377.103)
[[ commit created by automation ]]
Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25377.103 -> 5.0.0-2.25401.103) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25377.103 -> 10.0.0-preview.25401.103) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-preview.7.25377.103 -> 10.0.100-rc.1.25401.103) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25377.103 -> 10.0.0-beta.25401.103) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25377.103 -> 0.11.5-alpha.25401.103) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25377.103 -> 2.9.3-beta.25401.103) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-preview.7.25377.103 -> 10.0.0-rc.1.25401.103) System.CommandLine (Version 2.0.0-rc.1.25377.103 -> 2.0.0-rc.1.25401.103)
Important There are conflicts with the <Source Uri="https://github.com/dotnet/dotnet" Mapping="runtime" Sha="8b29a1682219da555ee27e4fdda55dc3884b316f" BarId="277635" /> In case of unclarities, consult the FAQ or tag @dotnet/product-construction for assistance. |
I'm looking into the NAOT failures. Looks like the runtime package isn't being discovered. Maybe some of the weird logic we have around restore for the test projects is causing an issue? I'll investigate |
I found the problem and added a workaround to our build. I'll file an issue on the dotnet/sdk repo to improve the experience. |
Filed dotnet/sdk#50093 for the underlying issue. |
Talked with @mmitche offline to confirm the fix for the |
<!-- emscripten / Node | ||
Note: when the name is updated, make sure to update dependency name in eng/pipelines/common/xplat-setup.yml | ||
like - DarcDependenciesChanged.Microsoft_NET_Workload_Emscripten_Current_Manifest-10_0_100_Transport | ||
--> | ||
<MicrosoftNETWorkloadEmscriptenCurrentManifest100100TransportVersion>10.0.100-preview.7.25367.101</MicrosoftNETWorkloadEmscriptenCurrentManifest100100TransportVersion> | ||
<MicrosoftNETRuntimeEmscriptenVersion>$(MicrosoftNETWorkloadEmscriptenCurrentManifest100100TransportVersion)</MicrosoftNETRuntimeEmscriptenVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akoeplinger Are the mono workload manifests still produced in runtime? I thought that got moved to sdk, but I see references in src/mono/nuget/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest/Microsoft.NET.Workload.Mono.Toolchain.Current.Manifest.pkgproj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they're not, I need to clean them up
<!-- BrowserDebugProxy libs --> | ||
<MicrosoftExtensionsLoggingVersion>3.1.7</MicrosoftExtensionsLoggingVersion> | ||
<MicrosoftSymbolStoreVersion>1.0.406601</MicrosoftSymbolStoreVersion> | ||
<!-- sdk version, for testing workloads --> | ||
<SdkVersionForWorkloadTesting>$(MicrosoftDotNetApiCompatTaskVersion)</SdkVersionForWorkloadTesting> | ||
<runtimewinx64MicrosoftNETCoreRuntimeWasmNodeTransportPackageVersion>10.0.0-alpha.1.25169.1</runtimewinx64MicrosoftNETCoreRuntimeWasmNodeTransportPackageVersion> | ||
<EmsdkPackageVersion>10.0.0-preview.7.25359.101</EmsdkPackageVersion> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@akoeplinger Similar question here...this is an n-1 (or earlier) version but shows up in src/mono/mono.proj
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
same here
Looks like some Mono failures felated to LibraryImport generator: Is someone available to take a look so we can get this unblocked? |
@tannergooding I'll take a look at those |
@MichalStrehovsky does ILC try to trim out any embedded resources? Seeing a few benchmark games tests fail and I logged #118475 for it. There's other tests in the same general folder that use the same embedded resources and aren't failing, but nothing obvious from the direct the changes in this PR that might cause it. |
It does not trim resources but the question is immaterial since the tests are neither AOT compiled nor trimmed in the failing legs. My guess would be an SDK change caused it but since the SDK repo doesn't believe in squashing commits, it's hard to pinpoint what caused it. Nobody is going to dig through dozens of "PR feedback" and "feedback" commits. |
This shouldn’t matter? It’s fairly trivial to look at just the merge heads and ignore any child commits. I’ll take a look through these tomorrow and see if I can spot any obvious changes |
[[ commit created by automation ]]
Updated Dependencies: Microsoft.CodeAnalysis, Microsoft.CodeAnalysis.Analyzers, Microsoft.CodeAnalysis.CSharp, Microsoft.Net.Compilers.Toolset (Version 5.0.0-2.25401.103 -> 5.0.0-2.25406.102) Microsoft.CodeAnalysis.NetAnalyzers (Version 10.0.0-preview.25401.103 -> 10.0.0-preview.25406.102) Microsoft.DotNet.ApiCompat.Task, Microsoft.NET.Workload.Emscripten.Current.Manifest-10.0.100.Transport (Version 10.0.100-rc.1.25401.103 -> 10.0.100-rc.1.25406.102) Microsoft.DotNet.Arcade.Sdk, Microsoft.DotNet.Build.Tasks.Archives, Microsoft.DotNet.Build.Tasks.Feed, Microsoft.DotNet.Build.Tasks.Installers, Microsoft.DotNet.Build.Tasks.Packaging, Microsoft.DotNet.Build.Tasks.TargetFramework, Microsoft.DotNet.Build.Tasks.Templating, Microsoft.DotNet.Build.Tasks.Workloads, Microsoft.DotNet.CodeAnalysis, Microsoft.DotNet.GenAPI, Microsoft.DotNet.GenFacades, Microsoft.DotNet.Helix.Sdk, Microsoft.DotNet.PackageTesting, Microsoft.DotNet.RemoteExecutor, Microsoft.DotNet.SharedFramework.Sdk, Microsoft.DotNet.XliffTasks, Microsoft.DotNet.XUnitExtensions (Version 10.0.0-beta.25401.103 -> 10.0.0-beta.25406.102) Microsoft.DotNet.Cecil (Version 0.11.5-alpha.25401.103 -> 0.11.5-alpha.25406.102) Microsoft.DotNet.XUnitAssert, Microsoft.DotNet.XUnitConsoleRunner (Version 2.9.3-beta.25401.103 -> 2.9.3-beta.25406.102) Microsoft.NET.Sdk.IL, Microsoft.NETCore.App.Ref, Microsoft.NETCore.ILAsm, runtime.native.System.IO.Ports, System.Reflection.Metadata, System.Reflection.MetadataLoadContext, System.Text.Json (Version 10.0.0-rc.1.25401.103 -> 10.0.0-rc.1.25406.102) Nuget.Frameworks, Nuget.Packaging, Nuget.ProjectModel, Nuget.Versioning (Version 6.2.4 -> 7.0.0-preview.1.102) System.CommandLine (Version 2.0.0-rc.1.25401.103 -> 2.0.0-rc.1.25406.102)
Important There are conflicts with the <Source Uri="https://github.com/dotnet/dotnet" Mapping="runtime" Sha="30bc8f92be07c2c8c3a6addb946877260e042f63" BarId="278224" /> In case of unclarities, consult the FAQ or tag @dotnet/product-construction for assistance. |
…aa-4cef-9a5c-884491b7a75d
Note
This is a codeflow update. It may contain both source code changes from the VMR as well as dependency updates. Learn more here.
This pull request brings the following source code changes
From https://github.com/dotnet/dotnet
Updated Dependencies
Associated changes in source repos