Add a copilot prompt file for JIT-EE interface modifications #115889
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@stephentoub @mrsharm @dotnet/jit-contrib opinions? |
Sounds cool, LGTM 🙂 |
jakobbotsch
reviewed
May 22, 2025
|
Tagging subscribers to this area: @JulieLeeMSFT, @jakobbotsch |
jakobbotsch
reviewed
May 23, 2025
Co-authored-by: Jakob Botsch Nielsen <[email protected]>
|
I would add "please" in a couple of places. Just in case.. |
Any hints where/study? 🙂 |
@jakobbotsch could you then approve it? 🙂 |
jakobbotsch
approved these changes
May 26, 2025
|
/ba-g "build analysis stuck" |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding new APIs to the JIT-EE interface is time-consuming and is difficult to automate: 15-16 files need to be updated with a complex (de)serialization logic in SPMI. So far, we’ve managed to automate generation for only 7 of those files; the rest still require manual edits. This prompt file (see Prompt Files feature) is designed to help with it. The typical workflow looks like this:
/add-new-jit-ee-api.prompt(there should be suggestions) and hit enterIt is supposed to ask for the signature (e.g.
CORINFO_METHOD_HANDLE getHelperHandle(int helperId)) and perform all the modifications (including thegen.shscript).Alternatively, you can type the signature right away
/add-new-jit-ee-api.prompt CORINFO_METHOD_HANDLE getHelperHandle(int helperId)It managed to successfully generate simple APIs for me (sometimes not from the first try). If it lands, I presume we can improve the prompt to handle more complex cases if it fails on them.