Skip to content

Ensure linux uses zlib-ng and not system ZLIB #105352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 24, 2024
Merged

Ensure linux uses zlib-ng and not system ZLIB #105352

merged 2 commits into from
Jul 24, 2024

Conversation

am11
Copy link
Member

@am11 am11 commented Jul 23, 2024 •
edited by ericstj
Loading

Fix cmake expression syntax in System.IO.Compression.Native.

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Jul 23, 2024
@am11 am11 mentioned this pull request Jul 23, 2024
Merged
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Tagging subscribers to this area: @dotnet/area-system-io-compression
See info in area-owners.md if you want to be subscribed.

@am11 am11 changed the title Fix expression syntax Fix cmake expression syntax in System.IO.Compression.Native Jul 23, 2024
carlossanlop
carlossanlop reviewed Jul 23, 2024
View reviewed changes
@ericstj ericstj changed the title Fix cmake expression syntax in System.IO.Compression.Native Ensure linux uses zlib-ng and not system ZLIB Jul 23, 2024
@am11
Copy link
Member Author

am11 commented Jul 23, 2024

Before:

ldd artifacts/bin/runtime/net9.0-linux-Release-arm64/libSystem.IO.Compression.Native.so
	linux-vdso.so.1 (0x0000ffff86e02000)
	libz.so.1 => /lib/aarch64-linux-gnu/libz.so.1 (0x0000ffff86c90000)
	libc.so.6 => /lib/aarch64-linux-gnu/libc.so.6 (0x0000ffff86ad0000)
	/lib/ld-linux-aarch64.so.1 (0x0000ffff86dc5000)

After:

ldd artifacts/bin/runtime/net9.0-linux-Release-arm64/libSystem.IO.Compression.Native.so 
	linux-vdso.so.1 (0x0000ffff8970d000)
	libc.so.6 => /lib/aarch64-linux-gnu/libc.so.6 (0x0000ffff89420000)
	/lib/ld-linux-aarch64.so.1 (0x0000ffff896d0000)

@carlossanlop
Copy link
Contributor

It's causing build failures.

@carlossanlop carlossanlop self-requested a review July 23, 2024 20:58
@carlossanlop
Copy link
Contributor

I applied the suggestion because the build is breaking and we're short on time since we need to backport this to Preview7 too.

@am11
Copy link
Member Author

am11 commented Jul 23, 2024

Yes macOS wasn't liking the syntax, while linux was passing. $<IF requires ${}, which works on both platforms.

@carlossanlop
Copy link
Contributor

/backport to release/9.0-preview7

@github-actions GitHub Actions
Copy link
Contributor

Started backporting to release/9.0-preview7: https://github.com/dotnet/runtime/actions/runs/10066382223

@github-actions github-actions bot mentioned this pull request Jul 23, 2024
Merged
4 tasks
@carlossanlop
Copy link
Contributor

carlossanlop commented Jul 23, 2024 •
edited
Loading

I see that most of the Unix build legs have finished and they were successful.

Strangely, the build is still breaking for me in ubuntu after applying the latest fix. I just ran ./build.sh:

  LibraryImportGenerator -> /home/carlos/repos/runtime/artifacts/bin/LibraryImportGenerator/Debug/netstandard2.0/Microsoft.Interop.LibraryImportGenerator.dll
  System.Private.CoreLib -> /home/carlos/repos/runtime/artifacts/bin/System.Private.CoreLib/ref/Debug/net9.0/System.Private.CoreLib.dll
  System.Private.CoreLib -> /home/carlos/repos/runtime/artifacts/bin/coreclr/linux.x64.Debug/IL/System.Private.CoreLib.dll
  cdac-build-tool -> /home/carlos/repos/runtime/artifacts/bin/coreclr/linux.x64.Debug/cdac-build-tool/cdac-build-tool.dll
  Generating native code
  /usr/bin/ld.bfd: cannot find -lz: No such file or directory
clang-17 : error : linker command failed with exit code 1 (use -v to see invocation) [/home/carlos/repos/runtime/src/native/managed/cdacreader/src/cdacreader.csproj]
/home/carlos/.nuget/packages/microsoft.dotnet.ilcompiler/9.0.0-preview.7.24371.6/build/Microsoft.NETCore.Native.targets(368,5): error MSB3073: The command ""clang" "/home/carlos/repos/runtime/artifacts/obj/cdacreader/Debug/net9.0/linux-x64/native/libcdacreader.o" -o "/home/carlos/repos/runtime/artifacts/bin/cdacreader/Debug/net9.0/linux-x64/native/libcdacreader.so" -Wl,--version-script=/home/carlos/repos/runtime/artifacts/obj/cdacreader/Debug/net9.0/linux-x64/native/libcdacreader.exports -Wl,--export-dynamic -Wl,-soname=cdacreader.so -gz=zlib -fuse-ld=bfd /home/carlos/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.7.24371.6/sdk/libbootstrapperdll.o /home/carlos/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.7.24371.6/sdk/libRuntime.WorkstationGC.a /home/carlos/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.7.24371.6/sdk/libeventpipe-disabled.a /home/carlos/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.7.24371.6/sdk/libRuntime.VxsortEnabled.a /home/carlos/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.7.24371.6/sdk/libstandalonegc-disabled.a /home/carlos/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.7.24371.6/sdk/libstdc++compat.a /home/carlos/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.7.24371.6/framework/libSystem.Native.a /home/carlos/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.7.24371.6/framework/libSystem.IO.Compression.Native.a /home/carlos/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.7.24371.6/framework/libSystem.Net.Security.Native.a /home/carlos/.nuget/packages/runtime.linux-x64.microsoft.dotnet.ilcompiler/9.0.0-preview.7.24371.6/framework/libSystem.Security.Cryptography.Native.OpenSsl.a -g -Wl,-rpath,'$ORIGIN' -Wl,--build-id=sha1 -Wl,--as-needed -Wl,-e0x0 -pthread -ldl -lz -lrt -lm -shared -Wl,-z,relro -Wl,-z,now -Wl,--eh-frame-hdr -Wl,--discard-all -Wl,--gc-sections" exited with code 1. [/home/carlos/repos/runtime/src/native/managed/cdacreader/src/cdacreader.csproj]

Still appending -lz.

@carlossanlop carlossanlop mentioned this pull request Jul 23, 2024
Closed
@am11
Copy link
Member Author

am11 commented Jul 23, 2024

Have you tried with a clean build:

rm -rf artifacts
./build.sh

@carlossanlop
Copy link
Contributor

Yes, it's completely clean.

Note that I do not have zlib1g-dev installed here. So I'm trying to determine why in my machine we're trying to use the system zlib.

@am11
Copy link
Member Author

am11 commented Jul 23, 2024

It's the build ordering issue. cdac-build-tool is built before clr and libs subsets, so it fails this condition:

runtime/src/coreclr/nativeaot/BuildIntegration/Microsoft.NETCore.Native.Unix.targets

Line 27 in 2c99cc5

<UseSystemZlib Condition="'$(UseSystemZlib)' == '' and !Exists('$(IlcFrameworkNativePath)libz.a')">true</UseSystemZlib>

and tries to use system libz.

@carlossanlop
Copy link
Contributor

I'm being told that this is expected but it's also temporary: cdacreader.csproj uses the LKG toolchain, so it won't have zlib-ng available until we consume an SDK that has it. The workaround is to keep installing zlib1g-dev.

@carlossanlop carlossanlop mentioned this pull request Jul 23, 2024
Closed
@build-analysis build-analysis bot mentioned this pull request Jul 24, 2024
Closed
@carlossanlop carlossanlop merged commit cb8dde8 into dotnet:main Jul 24, 2024
@am11 am11 deleted the patch-7 branch July 24, 2024 06:11
@LoopedBard3 LoopedBard3 mentioned this pull request Aug 1, 2024
Closed
@jkurdek jkurdek mentioned this pull request Aug 14, 2024
Closed
@github-actions github-actions bot locked and limited conversation to collaborators Aug 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jkoritzinsky jkoritzinsky jkoritzinsky approved these changes

+1 more reviewer

@carlossanlop carlossanlop carlossanlop approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
area-System.IO.Compression community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@am11 @carlossanlop @jkoritzinsky