Save runtime commit to productCommit-rid.txt #13132
Conversation
| <WriteLinesToFile | ||
| File="$(ArtifactsShippingPackagesDir)productCommit-$(Rid).txt" | ||
| Lines="$(BUILD_SOURCEVERSION)%0A$(PackageVersion)" | ||
| Lines="installer%3A$(BUILD_SOURCEVERSION)%2C%20$(PackageVersion)%0Aruntime%3A$(DepRuntimeCommit)%2C%20$(DepRuntimeVersion)%0A" |
There was a problem hiding this comment.
I think there are various things that consume this file, and we can't update the format without breaking them. It might be easier to create a new file for the runtime version.
There was a problem hiding this comment.
Do we know what those things are? Making a new file would be fine, but it is going to take a lot more work to plumb it through to the README.
It we want programs to consume this information, maybe we should make a new file that programs can consume, and that we can add to over time without breaking those programs.
There was a problem hiding this comment.
Changed PR to produce a new file productCommits-$(Rid).txt
There was a problem hiding this comment.
Sorry, I take back my feedback. I was confusing the productCommit-$(Rid).txt file which is part of the packages output folder with the .version and .toolsetversion files which are included in the SDK folder of the product.
Feel free to change the productCommit-$(Rid).txt file as you see fit. It is possible there's something that consumes it, but if so it would be in our build infrastructure, and we should be able to update it in response to the change.
There was a problem hiding this comment.
changed to productCommit-$(Rid).txt 🙂
…d-product-commit-txt
| <WriteLinesToFile | ||
| File="$(ArtifactsShippingPackagesDir)productCommit-$(Rid).txt" | ||
| Lines="$(BUILD_SOURCEVERSION)%0A$(PackageVersion)" | ||
| Lines="installer%3A$(BUILD_SOURCEVERSION)%2C%20$(PackageVersion)%0Aruntime%3A$(DepRuntimeCommit)%2C%20$(DepRuntimeVersion)%0A" |
There was a problem hiding this comment.
Sorry, I take back my feedback. I was confusing the productCommit-$(Rid).txt file which is part of the packages output folder with the .version and .toolsetversion files which are included in the SDK folder of the product.
Feel free to change the productCommit-$(Rid).txt file as you see fit. It is possible there's something that consumes it, but if so it would be in our build infrastructure, and we should be able to update it in response to the change.
| Overwrite="true" | ||
| Encoding="ASCII" /> | ||
|
|
||
| <GetDependencyInfo |
There was a problem hiding this comment.
In the same spirit, can WinForms version to be retreived and placed in this file? I would guess that SDK/WPF and WindowsDesktop versions maybe interested to somebody.
|
@dsplaisted can we merge this? I hit a case today where it would've been useful :) |
Done! |
Quite often users ask for daily builds with some recent fix inside, so they(us) need to quickly find the corresponding dotnet/runtime commit used in that latest daily build.
My understanding that currently you need to do something like this: dotnet/runtime#63285 (comment)
This PR saves dotnet/runtime's commit directly into productCommit-rid.txt so anyone can quickly match dotnet/runtime and the latest daily build right on the https://github.com/dotnet/installer/blob/main/README.md#installers-and-binaries page by clicking on "blue labels"