Skip to content

Conversation

jcagme
Copy link

@jcagme jcagme commented Mar 5, 2019

With this change all the official builds will generate the GraphViz ready content so it can be copied and pasted in http://www.webgraphviz.com/ to look at everything which is contained in that given build.

Test build: https://dnceng.visualstudio.com/internal/_build/results?buildId=114089

In the test build you can see there a new leg at the very end and it will only run when all the OS build legs and the Publish to BAR leg have completed successfully.

You can find the generated file in Artifacts > Windows_NT_Graph > graphviz.txt (code in this PR will actually put it in Artifacts > Graph > graphviz.txt

Note: I'm adding the script into eng/common since most likely this will be merged after Arcade has updated dependencies. Same script will be merged into Arcade's eng/common as well.

"skipciplease"

@jcagme
Copy link
Author

jcagme commented Mar 5, 2019

Looks like I cannot add reviewers so tagging people :)

@nguerrera @chcosta @mmitche

@jcagme
Copy link
Author

jcagme commented Mar 5, 2019

@chcosta comments addressed

Copy link
Member

@chcosta chcosta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you going to expose this functionality to all repos via an entry in eng\common\templates\jobs\jobs.yml? If you do, then the stuff in .vsts-ci.yml becomes largely throw away.

@jcagme
Copy link
Author

jcagme commented Mar 5, 2019

Are you going to expose this functionality to all repos via an entry in eng\common\templates\jobs\jobs.yml? If you do, then the stuff in .vsts-ci.yml becomes largely throw away.

Yes, SDK is the top of the graph so I wanted to tested here first. Eventually I'll make this an opt-in template where if something like create-graph=true then we run the thing.

@jcagme
Copy link
Author

jcagme commented Mar 5, 2019

Can someone in core-sdk help me merge this since I don't have permissions? @nguerrera

@nguerrera nguerrera merged commit 24946df into dotnet:master Mar 5, 2019
@jcagme jcagme deleted the graphViz branch March 5, 2019 21:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment