Don't include license file in sfx packages with license expressions #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Very similar to dotnet/runtime#115518 Don't include the LICENSE file in the shared framework produced packages if those set a PackageLicenseExpression. As mentioned in the other issue, Arcade already validates that either the license expression or the license file is set.
Interesting. |
|
@jkoritzinsky I'm inclined to close this as I don't have much resources to spend on this. Do you want to take this over or should we burry it for now? |
|
I don't have cycles to spend on this right now either. We can close and return to it later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Very similar to dotnet/runtime#115518
Don't include the LICENSE file in the shared framework produced packages if those set a PackageLicenseExpression.
As mentioned in the other issue, Arcade already validates that either the license expression or the license file is set.