Skip to content

Clarify/fix some threading docs #26041

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 13, 2021
Merged

Clarify/fix some threading docs #26041

merged 3 commits into from
Sep 13, 2021

Conversation

kouvel
Copy link
Contributor

@kouvel kouvel commented Sep 10, 2021 •
edited
Loading

Clarify/fix some threading docs
11724ec 
- Document new settings available to configure the rate of thread injection for sync-over-async. Fixes #24566.
- Clarify documentation of the `volatile` keyword. Fixes #24318.
- Add link to clarify some terms in `LazyThreadSafetyMode` field names. Fixes #12214.
@kouvel kouvel requested review from gewarren and mangod9 September 10, 2021 18:08
@kouvel kouvel requested review from a team and BillWagner as code owners September 10, 2021 18:08
@kouvel kouvel self-assigned this Sep 10, 2021
@dotnet-bot dotnet-bot added this to the September 2021 milestone Sep 10, 2021
gewarren
gewarren approved these changes Sep 10, 2021
View reviewed changes
gewarren
gewarren reviewed Sep 10, 2021
View reviewed changes
@kouvel @gewarren
Apply suggestions from code review
489e3d3 
Thank you!

Co-authored-by: Genevieve Warren <[email protected]>
BillWagner
BillWagner approved these changes Sep 13, 2021
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This LGTM @kouvel

Once the related PR is merged, let's :shipit:

@kouvel kouvel merged commit 8ce731c into dotnet:main Sep 13, 2021
@kouvel kouvel deleted the ThDocs branch September 13, 2021 17:42
@kouvel kouvel mentioned this pull request Sep 14, 2021
Closed
24 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@gewarren gewarren gewarren approved these changes

@BillWagner BillWagner BillWagner approved these changes

@mangod9 mangod9 Awaiting requested review from mangod9

Assignees

@kouvel kouvel

Labels

dotnet-csharp/svc dotnet-framework/svc dotnet-fundamentals/svc lang-reference/subsvc

Projects

None yet

Milestone

September 2021

4 participants

@kouvel @BillWagner @gewarren @dotnet-bot