Skip to content

Add documentation about new ReadyToRun publish options #25780

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Sep 1, 2021
Merged

Add documentation about new ReadyToRun publish options #25780

merged 3 commits into from
Sep 1, 2021

Conversation

davidwrighton
Copy link
Member

  • Composite R2R
  • Symbol generation
  • Exclusion from R2R
  • Updated cross-targetting details

@davidwrighton
Add documentation about:
edfb372 
- Composite R2R
- Symbol generation
- Exclusion from R2R
- Updated cross-targetting details
@dotnet-bot dotnet-bot added this to the August 2021 milestone Aug 24, 2021
@davidwrighton
Copy link
Member Author

@mangod9, @trylek

I think documenting the composite, symbol generation and r2r excludes features are the right ones to doc at this time. @trylek, can you tell me if there are any other details about symbol publishing that I should be documenting?

trylek
trylek previously approved these changes Aug 25, 2021
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for improving the documentation David! AFAIK you've covered the important bits, I'm not aware of any other user-facing SDK capabilities regarding Crossgen2. At some point it might be useful to document the E2E symbol-related scenarios but that's beyond the scope of your pending change.

@davidwrighton davidwrighton marked this pull request as ready for review September 1, 2021 00:39
@davidwrighton davidwrighton requested a review from trylek September 1, 2021 00:39
@davidwrighton
Copy link
Member Author

@trylek, could you review the additional change I made about the symbol generation?

@davidwrighton davidwrighton dismissed trylek’s stale review September 1, 2021 00:39

I want another review.

trylek
trylek approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The additional delta looks good to me too, thanks David!

trylek
trylek approved these changes Sep 1, 2021
View reviewed changes
Copy link
Member

@trylek trylek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the clarifying comment!

@davidwrighton davidwrighton mentioned this pull request Sep 1, 2021
Closed
24 tasks
@davidwrighton davidwrighton merged commit ae84909 into dotnet:main Sep 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@trylek trylek trylek approved these changes

@adegeo adegeo Awaiting requested review from adegeo adegeo is a code owner

Assignees

No one assigned

Labels

dotnet-fundamentals/svc

Projects

None yet

Milestone

September 2021

Development

Successfully merging this pull request may close these issues.

4 participants

@davidwrighton @trylek @BillWagner @dotnet-bot