Only ping build-ops for main #62381
Only ping build-ops for main #62381
Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR refines dependency update policies to ensure that build-ops are only notified for PRs targeting the main branch.
- Added targetsBranch condition for policies with noActivitySince of 1 day.
- Added targetsBranch condition for policies with noActivitySince of 3 days.
| action: Opened | ||
| - isActivitySender: | ||
| user: dotnet-maestro[bot] | ||
| issueAuthor: False |
There was a problem hiding this comment.
out of curiosity, what does issueAuthor mean in this case? wouldn't dotnet-maestro be the author of the PR if this is an opened action?
There was a problem hiding this comment.
The docs aren't super clear, but my understanding is that you use that when you want to trigger on an action taken by the author of the issue/PR, rather than on one specific user (see line 389).
| @@ -709,6 +733,8 @@ configuration: | |||
| label: area-infrastructure | |||
| - addLabel: | |||
| label: 'Type: Dependency Update :arrow_up_small:' | |||
| - addLabel: | |||
| label: 'build-ops' | |||
There was a problem hiding this comment.
I still see several uses like right above this one for the Type: Dependency Update... labels. Do we still need them or is it okay to just use build-ops label going forward? And if so, can we remove the old labels?
There was a problem hiding this comment.
I like having the different types of labels to differentiate between the different types of automated PRs. Also the split isn't uniform (e.g. build-ops looks at a set of auto-merge & dependency PRs, but they don't look at all auto-merge & dependency PRs - they don't look at servicing)
There was a problem hiding this comment.
fair enough, just wanted to check in case they weren't needed any longer.
|
/ba-g config-only change |
Update new actions to only bug build-ops for PRs against main
This pull request updates the
.github/policies/resourceManagement.ymlfile to refine the conditions for dependency update policies. The changes introduce a newtargetsBranchcondition to ensure the policies apply specifically to themainbranch.Dependency update policy refinements:
.github/policies/resourceManagement.yml: Added atargetsBranchcondition to specify that thebranchmust bemainfor the policy triggered bynoActivitySince: days: 1..github/policies/resourceManagement.yml: Added atargetsBranchcondition to specify that thebranchmust bemainfor the policy triggered bynoActivitySince: days: 3.