Skip to content

Done should also be optional with multiple locks #7

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Harrison-M wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Done should also be optional with multiple locks #7

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ module.exports = function () {
var args = [].slice.call(arguments)
for(var key in l)
_release(key, l[key])
done.apply(this, args)
if (done) done.apply(this, args)
}
}

Expand Down
16 changes: 16 additions & 0 deletions test/multi.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -58,3 +58,19 @@ tape('wait for a single lock', function (t) {
})()
})
})

tape('multiple locks with optional done', function (t) {
var lock = Lock(), released = 0

lock(['a', 'b'], function (release) {
released = 1
process.nextTick(release())
})

lock(['a', 'b'], function (release) {
t.equal(released, 1, 'first lock should be completely released')
release(function () {
t.end()
})()
})
})