Skip to content

image/tree: Don't limit name width if non tty #6656

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Nov 13, 2025
Merged

image/tree: Don't limit name width if non tty #6656

merged 2 commits into from
Nov 13, 2025
+24 −25

Conversation

@vvoland
Copy link
Collaborator

@vvoland vvoland commented Nov 13, 2025 •
edited
Loading

Previously when no terminal was attached the width was assumed to be 80.
This is too short for most image names which truncated the names when output was redirect (for example to grep).

This disabled the name truncation if the terminal width can't be determined.

`docker image ls` no longer truncates the name width when output is redirect (e.g. for `grep`).

@vvoland vvoland added this to the 29.0.1 milestone Nov 13, 2025
@vvoland vvoland self-assigned this Nov 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Nov 13, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 82.35294% with 3 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/image/tree.go 82.35% 2 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@vvoland vvoland force-pushed the img-list-notty-width branch from 14c6598 to dc0e57f Compare November 13, 2025 11:18
@vvoland vvoland mentioned this pull request Nov 13, 2025
Open
@vvoland vvoland requested a review from thaJeztah November 13, 2025 11:21
@vvoland vvoland force-pushed the img-list-notty-width branch from dc0e57f to f9f612d Compare November 13, 2025 11:40
robmry
robmry reviewed Nov 13, 2025
View reviewed changes
Copy link
Contributor

@robmry robmry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except for ...

@vvoland
image/tree: Don't limit name width if non tty
aa5d00a 
Previously when no terminal was attached the width was assumed to be 80.
This is too short for most image names which truncated the names when
output was redirect (for example to `grep`).

This disabled the name truncation if the terminal width can't be
determined.

Signed-off-by: Paweł Gronowski <[email protected]>
@vvoland
image/list: Print legend only if limiting width
ed281dd 
Signed-off-by: Paweł Gronowski <[email protected]>
@vvoland vvoland force-pushed the img-list-notty-width branch from f9f612d to ed281dd Compare November 13, 2025 12:00
thaJeztah
thaJeztah approved these changes Nov 13, 2025
View reviewed changes
Copy link
Member

@thaJeztah thaJeztah left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thaJeztah thaJeztah merged commit 2ae51e2 into docker:master Nov 13, 2025
91 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thaJeztah thaJeztah thaJeztah approved these changes

@robmry robmry robmry approved these changes

Assignees

@vvoland vvoland

Labels

area/ux impact/changelog kind/bugfix PR's that fix bugs

Projects

None yet

Milestone

29.0.1

Development

Successfully merging this pull request may close these issues.

4 participants

@vvoland @codecov-commenter @thaJeztah @robmry