Skip to content

Conversation

thaJeztah
Copy link
Member

Name is a required argument for both "create" and "update", so better to split it from the options struct.

- How to verify it

- Human readable description for the release notes

- A picture of a cute animal (not mandatory but encouraged)

Name is a required argument for both "create" and "update", so better
to split it from the options struct.

Signed-off-by: Sebastiaan van Stijn <[email protected]>
@thaJeztah thaJeztah added this to the 29.0.0 milestone Sep 10, 2025
@thaJeztah thaJeztah added status/2-code-review area/context kind/refactor PR's that refactor, or clean-up code labels Sep 10, 2025
@codecov-commenter
Copy link

Codecov Report

❌ Patch coverage is 80.00000% with 4 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
cli/command/context/update.go 57.14% 1 Missing and 2 partials ⚠️
cli/command/context/create.go 92.30% 1 Missing ⚠️

📢 Thoughts on this report? Let us know!

@thaJeztah thaJeztah requested a review from Benehiko September 10, 2025 12:31
@thaJeztah thaJeztah merged commit e78f169 into docker:master Sep 10, 2025
112 of 115 checks passed
@thaJeztah thaJeztah deleted the context_name_positional branch September 10, 2025 13:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/context kind/refactor PR's that refactor, or clean-up code status/2-code-review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants