Skip to content

Refs #35667 -- Cached Django file prefixes for warnings. #19823

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 12, 2025
Merged

Refs #35667 -- Cached Django file prefixes for warnings. #19823

merged 1 commit into from
Sep 12, 2025
+38 −5

Conversation

adamchainz
Copy link
Member

Trac ticket number

ticket-35667

Branch description

This change makes repeated warnings with skip_file_prefixes more efficient by avoiding repeating the construction (os.path.dirname(django.__file__),).

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

@adamchainz adamchainz mentioned this pull request Sep 5, 2025
Open
6 tasks
jacobtylerwalls
jacobtylerwalls reviewed Sep 5, 2025
View reviewed changes
Copy link
Member

@jacobtylerwalls jacobtylerwalls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@adamchainz adamchainz force-pushed the ticket_35667 branch 2 times, most recently from ede0880 to 758e84d Compare September 11, 2025 09:49
@adamchainz
Refs #35667 -- Cached Django file prefixes for warnings.
e9e8acf 
This change makes repeated warnings with `skip_file_prefixes` more efficient by
avoiding repeating the construction `(os.path.dirname(django.__file__),)`.
@felixxm felixxm merged commit 7b26b64 into django:main Sep 12, 2025
32 checks passed
@nessita nessita mentioned this pull request Sep 12, 2025
Merged
@adamchainz adamchainz deleted the ticket_35667 branch September 17, 2025 10:23
@jacobtylerwalls jacobtylerwalls mentioned this pull request Sep 24, 2025
Open
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixxm felixxm felixxm left review comments

@jacobtylerwalls jacobtylerwalls jacobtylerwalls left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@adamchainz @felixxm @jacobtylerwalls