Fixed #36350 -- Respected Field.db_check() when deciding whether to recreate constraint #19416
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
508af06 to
099abcb
Compare
…create constraint This is a regression introduced by 9953c80
13ea25a to
b0467f2
Compare
b0467f2 to
a74954a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-36350
Branch description
This PR changes the logic in BaseDatabaseSchemaEditor._field_db_check() to make use of Field.db_check() instead of looking up constraints in connection.data_type_check_constraints. This re-enable custom fields being able to manage their own constraints.
Checklist
mainbranch.