Skip to content

Fixed #36318 -- Fixed incorrect rollback exception attribution in nested atomic blocks. #19391

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fixed #36318 -- Fixed incorrect rollback exception attribution in nested atomic blocks. #19391

wants to merge 1 commit into from

Conversation

JaeHyuckSa
Copy link
Contributor

Trac ticket number

ticket-36318

Branch description

Prevented rollback_exc from leaking exceptions between unrelated atomic blocks.
Ensures correct exception attribution in TransactionManagementError.

Thank you, @charettes, for your guidance.

Checklist

  • This PR targets the main branch.
  • The commit message is written in past tense, mentions the ticket number, and ends with a period.
  • I have checked the "Has patch" ticket flag in the Trac system.
  • I have added or updated relevant tests.
  • I have added or updated relevant docs, including release notes if applicable.
  • I have attached screenshots in both light and dark modes for any UI changes.

@kevingill1966
Copy link

I reviewed this fix.

  1. The fix resolves the problem.
  2. The tests work correctly. If the fix is not in place, they raise an error.
  3. black, sort, flake8 and blacken-docs all pass the change.

I recommend that the author finalises the documentation for release.

  1. Add the release note
  2. Prepare a commit message in line with the guidelines.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@JaeHyuckSa @kevingill1966