Added DatabaseFeatures.rounds_to_even. #18948
Conversation
This is useful with MongoDB.
3900b0b to
a545d76
Compare
There was a problem hiding this comment.
Thank you @timgraham! This looks like a well-isolated and uncontroversial change. However, I feel uneasy about merging this, as in the past, I've seen similar proposals rejected for not being directly used within Django core.
Do you have any references to previous merges that set a precedent for landing a change like this?
|
I don't think it's controversial to add feature flags to support third-party database backends, so that they don't have to use a heavily forked version of the test suite. (Consider the possibility of moving a built-in backend like Oracle to a third-party package... I wouldn't propose to remove all of the Oracle feature flags in the test suite.) Certainly there could be some esoteric behaviors that impose too high a maintenance burden in the test suite, but I would say flags like this one are largely up to the third-party backends to keep up to date since patches with new tests in Django can't consider every third-party backend. I upstreamed nearly all of the changes I needed for CockroachDB. Here are a few: I don't anticipate being able to do the same for MongoDB since many of the changes are not appropriate, but this seemed like an easily described behavior that a SQL database could have. Feel free to ping me on any feature flag proposals that come up in the future. I can't think of any that I rejected in the past, but I have forgotten a lot. |
We always tried to encourage folks to build new database backends as a third party solutions. Assuring them that making small tweaks to the base backend to make their life easier is not a problem. |
|
Thank you both, this information is really helpful! |
This is something that we should share publicly (e.g. in the database documentation) to encourage folks that want to build new database backends. |
This is useful with MongoDB.