Fixed #34521 -- Added __slots__ to several template classes. #18649
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kezabelle
reviewed
Oct 4, 2024
2ccb3ed to
46f3217
Compare
Template parsing instantiates one lexer per template and many tokens per template, so using __slots__ to reduce the memory footprint of these classes is worthwhile for performance.
Parsed templates may contain many NodeList instances, so using __slots__ to reduce the memory footprint of these classes is worthwhile for performance.
46f3217 to
0fec865
Compare
0fec865 to
3b56850
Compare
|
I've just pushed new version with the change split into three commits, addressing @kezabelle 's review. |
Templates can contain many nodes, so using __slots__ to reduce the memory footprint of Node classes is worthwhile for performance. Attributes named in `__slots__` cannot be set at the class level, so this has needed an adjustment to `Node` to make `token` and `origin` instance attributes instead of class attributes. `Node` classes in Django and many packages do not call `super().__init__()` in their `__init__()` methods, because they have never had to, so `Node.__new__()` has been overridden to set these attributes for new instances instead of using `Node.__init__()`.
3b56850 to
4380c21
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trac ticket number
ticket-34521
Branch description
Following this forum discussion, this PR is a repeat of #16805, but limited to just
Nodeclasses andNodeList, to deal with compatibility concerns. According to my benchmark, this change saves about 20% of the memory for templates and speeds up rendering by up to 6%.Because attributes named in
__slots__cannot be class attributes,Node.tokenandNodeList.contains_nontexthave been converted to instance attributes, defined in__init__(). This change requires that all their subclasses callsuper().__init__(), which was not the case previously.Checklist
mainbranch.