Add test for gin index using LOWER #18119
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation has a LOWER example, but no coverage for it.
sarahboyce
pushed a commit
to nmenezes0/django
that referenced
this pull request
May 21, 2024
Thanks Claude Paroz for the review. Co-authored-by: Nina Menezes <[email protected]>
sarahboyce
pushed a commit
that referenced
this pull request
May 21, 2024
Thanks Claude Paroz for the review. Co-authored-by: Nina Menezes <[email protected]>
gabn88
pushed a commit
to gabn88/django
that referenced
this pull request
Jun 4, 2024
Thanks Claude Paroz for the review. Co-authored-by: Nina Menezes <[email protected]>
4 tasks
sarahboyce
pushed a commit
to medmunds/django
that referenced
this pull request
Dec 13, 2024
The "Trivial case failed. Try for possible IDN domain" handling was obsoleted by ticket-20003, which adjusted the regular expressions to allow all international domain names (Refs #20003). Uses of `ul` were moved to DomainNameValidator in ticket-18119 (Refs django#18119).
sarahboyce
pushed a commit
that referenced
this pull request
Dec 13, 2024
The "Trivial case failed. Try for possible IDN domain" handling was obsoleted by ticket-20003, which adjusted the regular expressions to allow all international domain names (Refs #20003). Uses of `ul` were moved to DomainNameValidator in ticket-18119 (Refs #18119).
ryancheley
pushed a commit
to ryancheley/django
that referenced
this pull request
Dec 29, 2024
The "Trivial case failed. Try for possible IDN domain" handling was obsoleted by ticket-20003, which adjusted the regular expressions to allow all international domain names (Refs #20003). Uses of `ul` were moved to DomainNameValidator in ticket-18119 (Refs django#18119).
gtossou
pushed a commit
to gtossou/django
that referenced
this pull request
Apr 4, 2025
The "Trivial case failed. Try for possible IDN domain" handling was obsoleted by ticket-20003, which adjusted the regular expressions to allow all international domain names (Refs #20003). Uses of `ul` were moved to DomainNameValidator in ticket-18119 (Refs django#18119).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DRAFT please come back later.