Fixed #18233: Raise IOError if destination file already exists, in django.core.files.move.file_move_safe. #18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great work with the individual commit with tests ! |
django.core.files.move.file_move_safe.
There was a problem hiding this comment.
It's best practice to use common string substitution.
|
I am closing this pull request as the ticket discussions indicate this isn't 100% ready for commit. |
nanuxbe
pushed a commit
to nanuxbe/django
that referenced
this pull request
Jul 2, 2016
Update to a properly packaged django-push
davegaeddert
referenced
this pull request
in dropseed/plain
Apr 26, 2023
davegaeddert
referenced
this pull request
in dropseed/plain
Apr 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On certain platforms like Linux, the existing code will simply ignore
allow_overwriteand go ahead and overwrite the destination file anyway. This fixes it.ps. This is also my first contribution to Django :)