Fixed #14611 -- Added query_params argument to RequestFactory and Client classes. #17447
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faab61c to
a261b76
Compare
shangxiao
reviewed
Nov 6, 2023
felixxm
reviewed
Nov 16, 2023
docs/topics/testing/tools.txt
Outdated
There was a problem hiding this comment.
versionchanged annotations are missing for every method.
There was a problem hiding this comment.
query_params=None is missing in AsyncClient and Client signatures and docs.
|
@knyghty Thanks 👍 We can keep both |
|
@felixxm Yes, this week I think, thanks 👍🏻 |
|
@felixxm these are both done now. |
…nd Client classes.
felixxm
approved these changes
Nov 23, 2023
docs/topics/testing/tools.txt
Outdated
There was a problem hiding this comment.
query_params=None is missing in AsyncClient and Client signatures and docs.
docs/topics/testing/tools.txt
Outdated
There was a problem hiding this comment.
query_params is missing in the head() signature and docs.
d3801df to
a035939
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.