Fixed #34781 -- Updated logging ref docs for django.server's request extra context value. #17172
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…extra context value.
ec5a791 to
5de5381
Compare
django.server
nessita
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Approving on the basis that the docs for simple_server.WSGIRequestHandler confirms the request is a socket.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ticket is https://code.djangoproject.com/ticket/34781.
I've not touched the
django.requestequivalent, though I presume that always receives anHttpRequestsubclass instance, in the same way I am presuming that the.requestunderdjango.serveris always the raw socket ... 🤷Of course, if anyone can figure out a way to get the actual request, that'd be a much better win ;)