Skip to content

Refs #34316 -- Fixed layout of admin password change forms and help texts for RTL languages. #16684

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 24, 2023
Merged

Refs #34316 -- Fixed layout of admin password change forms and help texts for RTL languages. #16684

merged 1 commit into from
Mar 24, 2023

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Mar 24, 2023

Regression in 96a5983.

Follow up to e678046 and 39d1e45.

Before:

image

After:

image

@felixxm felixxm requested a review from a team March 24, 2023 12:11
@felixxm
Copy link
Member Author

felixxm commented Mar 24, 2023

buildbot, test on selenium.

sarahboyce
sarahboyce reviewed Mar 24, 2023
View reviewed changes
Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just minor comments
Also out of curiosity, has Please correct the errors below been missed from the translations?

@felixxm felixxm force-pushed the rtl-admins-password branch from 9f95767 to f8f569b Compare March 24, 2023 12:51
@felixxm felixxm force-pushed the rtl-admins-password branch from f8f569b to d97c2d1 Compare March 24, 2023 12:52
sarahboyce
sarahboyce approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@sarahboyce sarahboyce left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice 🎉

@felixxm
Copy link
Member Author

felixxm commented Mar 24, 2023

@sarahboyce Thanks for checking 👍

Also out of curiosity, has Please correct the errors below been missed from the translations?

Probably, can check this later.

@felixxm felixxm merged commit f5c5c57 into django:main Mar 24, 2023
@felixxm felixxm deleted the rtl-admins-password branch March 24, 2023 19:48
@ngnpope ngnpope mentioned this pull request Nov 30, 2023
Draft
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sarahboyce sarahboyce sarahboyce approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@felixxm @sarahboyce