Please look at my comments regarding use of None instead of "" for self.end on the previous PR. This hasn't been considered yet.

Please look at my comments regarding use of None instead of "" for self.end on the previous PR. This hasn't been considered yet.

Hi Nick,
I actually did try to implement replacing "" with None for self.end, the way you proposed in the previous PR, but it ended up breaking the code later in the execution. So my question is should I just do it like this

if self.end is None:
          return f"{lhs}[%s:%s]", params + [self.start, self.end]
      else:
          return f"{lhs}[%s:]", params + [self.start]

because None is not expected by compiler.py later and ends up not working.

Thanks for looking @SirAbhi13. I did get that working as there were two placed that needed to be updated.

I've been having a further look into this and have some reservations about the design. Going to have a little play to see if I can think how this might work better.

I did end up getting the None value working, turns out I was making a mistake during testing on my part.
May I know which part in the suggested changes you have reservations about?

The tests that are failing are for mysql and maria db, because they are evaluating the queries in case insensitive mode, hence returning values in testcases where empty queryset is expected. I Will have to research on how to prevent that.

@ngnpope

Hi @ngnpope, were you able to have any thinking about the design proposed here? Any suggestions to move this forward get this solved? 🤔

Hey @SirAbhi13. I think quite some time has passed so I've lost track of where I was going with that thought.

I did find a local branch with a bunch of fixes though, so I've polished that off and put up #17596 to get this over the line.

Thanks for the reminder and your efforts to help push this forward. Quite the number of co-authors on this one!

@ngnpope Glad to have helped! I think the issue with MariaDB and mysql still needs to be looked at as I mentioned in my earlier comment regarding case sensitivity (IIRC) and I wasn't able to find any solution for this.