Fixed #33199 -- Deprecated passing positional arguments to Signer/TimestampSigner. #16343
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
felixxm
reviewed
Dec 2, 2022
There was a problem hiding this comment.
@SirAbhi13 Thanks for this patch 👍 Please check my comments. Also, we should add deprecated annotations to the Signer and TimestampSigner docs, and update some examples.
|
@SirAbhi13 Thanks for updates 👍 I pushed small edits. |
…estampSigner. Thanks Jacob Walls for the implementation idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes ticket 33199
Added an *args argument to
Signerto handle positional arguments sent to it and raise Deprecation warning.I modified the tests of Signer to give keyword arguments to all the tests. Unsure if I should have added an ignore warning decorator instead.