Skip to content

Removed obsolete assertions in BooleanFieldTests.test_return_type(). #15759

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 3, 2022
Merged

Removed obsolete assertions in BooleanFieldTests.test_return_type(). #15759

merged 1 commit into from
Jun 3, 2022

Conversation

felixxm
Copy link
Member

@felixxm felixxm commented Jun 3, 2022 •
edited
Loading

Added in e9bbdb3.

Obsolete since e910340.

It also crashes on PostgreSQL 15 beta 1, probably because string has some special meaning. For example, using:

.extra(select={"id_col": "id"})

doesn't crash. I couldn't find anything about string in PostgreSQL 15's release notes, but this column name is definitely unfortunate.

@felixxm felixxm requested a review from a team June 3, 2022 07:57
David-Wobrock
David-Wobrock approved these changes Jun 3, 2022
View reviewed changes
Copy link
Member

@David-Wobrock David-Wobrock left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The patch looks good to me 👍
I'm wondering what other impacts the PostgreSQL change could have on Django 🤔

@felixxm
Copy link
Member Author

felixxm commented Jun 3, 2022

@David-Wobrock Thanks for checking 👍

The patch looks good to me +1 I'm wondering what other impacts the PostgreSQL change could have on Django thinking

This is the only test that fails. Any change around string special meaning should have no impact on Django itself, since identifiers are quoted in other cases and we don't use add_extra() internally.

@felixxm felixxm merged commit aaf0045 into django:main Jun 3, 2022
@felixxm felixxm deleted the refs-13293-obsolete branch June 3, 2022 19:29
artirix1927 added a commit to artirix1927/django that referenced this pull request Aug 18, 2025
@artirix1927
Fixed django#15759 - Excluded formset fields by per-object permissions
ffa57a2
artirix1927 added a commit to artirix1927/django that referenced this pull request Aug 18, 2025
@artirix1927
Fixed django#15759 - Excluded formset fields by per-object permissions
3b4afa6
artirix1927 added a commit to artirix1927/django that referenced this pull request Aug 18, 2025
@artirix1927
Fixed django#15759 - Excluded formset fields by per-object permissions
a613569
artirix1927 added a commit to artirix1927/django that referenced this pull request Aug 18, 2025
@artirix1927
Fixed django#15759 - Excluded formset fields by per-object permissions
d993175
artirix1927 added a commit to artirix1927/django that referenced this pull request Aug 18, 2025
@artirix1927
Fixed django#15759 - Excluded formset fields by per-object permissions
35676b8
artirix1927 added a commit to artirix1927/django that referenced this pull request Aug 18, 2025
@artirix1927
Fixed django#15759 - Excluded formset fields by per-object permissions
72fa56a
artirix1927 added a commit to artirix1927/django that referenced this pull request Aug 18, 2025
@artirix1927
Fixed django#15759 - Excluded formset fields by per-object permissions
49d2c0f
artirix1927 added a commit to artirix1927/django that referenced this pull request Aug 18, 2025
@artirix1927
Fixed django#15759 - Excluded formset fields by per-object permissions
c35c902
artirix1927 added a commit to artirix1927/django that referenced this pull request Aug 18, 2025
@artirix1927
Fixed \django#15759 - Excluded formset fields by per-object permissions
4656e4d
artirix1927 added a commit to artirix1927/django that referenced this pull request Oct 2, 2025
@artirix1927
Fixed \django#15759 - Excluded formset fields by per-object permissions
09def8f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@hramezani hramezani hramezani approved these changes

@David-Wobrock David-Wobrock David-Wobrock approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@felixxm @hramezani @David-Wobrock