Fixed #33460 -- Used VALUES clause for insert in bulk on SQLite. #15354
Conversation
8ed1ded to
ea8cceb
Compare
|
Tests all passed, but now I've force pushed over the top and so we must go again ;) From the current SQLite docs:
The |
VALUES (..., ...)SQLite 3.7.11 introduced the ability to use multiple values directly. SQLite 3.8.8 made multiple values not subject to the SQLITE_LIMIT_COMPOUND_SELECT (500).
ea8cceb to
c27932e
Compare
|
@kezabelle Thanks 👍 |
|
@kezabelle We should update django/django/db/backends/sqlite3/operations.py Lines 37 to 38 in 4ac0bf6 |
Yeah, I 100% agree, wasn't planning on even trying to add it to this PR. I need to do some playing around with the batch sizing and the max params and how/where any pain points might occur, but doing so [with any success] requires this PR having landed ... and time ;) |
Edit: ticket is 33460
Instead of using the old work-around of
UNION ALL SELECT ...SQLite 3.7.11 introduced the ability to use multiple values directly; SQLite 3.9 is Django's currently documented minimum supported version.
This looks to have a potentially positive effect on
django.db.backends.sqlite3.features.DatabaseFeatures.max_query_params; prior to this change, increasing that value (e.g due to using3.32+to get at higherSQLITE_MAX_VARIABLE_NUMBER) would cause testlookup.tests.LookupTests.test_in_bulk_lots_of_idsto fail withdjango.db.utils.OperationalError: too many terms in compound SELECTbut doesn't have that problem afterwards.(SQLite 3.8.8 made multiple values not subject to the
SQLITE_LIMIT_COMPOUND_SELECT)Queries executed changes from:
to:
Let's see what CI says, for a start!