Fixed #32201 -- Removed obsolete isort:skip's. #13687
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Obsolete as of isort 5.0
1ad329b to
060a88c
Compare
seamus-quinn
commented
Nov 17, 2020
This comment has been minimized.
This comment has been minimized.
|
@seamus-quinn Thanks 👍 Welcome aboard ⛵ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
isort:skipTicket
https://code.djangoproject.com/ticket/32201#no3
Questions
django/docs/internals/contributing/writing-code/coding-style.txtcontains reference toisort:skip. I was unsure if this needed to be updated to reflect that it is no longer being used.