Fixed #20746 -- Removed Python 2.6 specific code/docs #1356
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
No longer needed with the drop of Python 2.6 support.
…on 2.6 is not supported.
django/utils/itercompat.py
Outdated
There was a problem hiding this comment.
Shouldn't this be return isinstance(x, collections.Iterator) instead? Actually we should replace all reference to this function by a collection.Iterator instance check.
There was a problem hiding this comment.
I'm not sure that this admonition should be removed. AFAIK the situation is unchanged, apart that a Jython 2.7 beta is now available.
There was a problem hiding this comment.
My thought was that by the time Django 1.7 is released, it will have been in the docs for 2 releases and probably no longer needed. Don't really care though.
|
Besides the two comments above, this looks good, thank you! |
|
merged in 2456ffa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.