Skip to content

Refs #30573 -- Rephrased "Of Course" and "Obvious(ly)" in documentation and comments. #12838

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
May 4, 2020
Merged

Refs #30573 -- Rephrased "Of Course" and "Obvious(ly)" in documentation and comments. #12838

merged 2 commits into from
May 4, 2020

Conversation

adamchainz
Copy link
Member

Following #11482, this phrase also implies the reader should already know or have realized what is being said.

@adamchainz
Copy link
Member Author

@rixx thanks for the original change

@adamchainz adamchainz mentioned this pull request May 1, 2020
Merged
@adamchainz adamchainz changed the title Removed phrase "Of Course" from documentation. Rephrased "Of Course" and "Obvious(ly)" in documentation and comments. May 1, 2020
@felixxm felixxm changed the title Rephrased "Of Course" and "Obvious(ly)" in documentation and comments. Refs #30573 -- Rephrased "Of Course" and "Obvious(ly)" in documentation and comments. May 4, 2020
@felixxm felixxm self-assigned this May 4, 2020
felixxm
felixxm reviewed May 4, 2020
View reviewed changes
Copy link
Member

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adamchainz Thanks 👍 I pushed small edits.

@felixxm felixxm force-pushed the of_course branch 2 times, most recently from 52d79f5 to 0ec87f6 Compare May 4, 2020 09:02
adamchainz
adamchainz commented May 4, 2020
View reviewed changes
@felixxm felixxm merged commit d17b380 into django:master May 4, 2020
@adamchainz adamchainz deleted the of_course branch May 6, 2020 09:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@felixxm felixxm felixxm left review comments

Assignees

@felixxm felixxm

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@adamchainz @felixxm