Skip to content

Conversation

@mdlinville
Copy link
Contributor

Backport of #2282

@mdlinville mdlinville requested a review from stevvooe May 23, 2017 18:27
@codecov
Copy link

codecov bot commented May 23, 2017

Codecov Report

Merging #2284 into release/2.6 will decrease coverage by 10.07%.
The diff coverage is n/a.

Impacted file tree graph

@@               Coverage Diff                @@
##           release/2.6    #2284       +/-   ##
================================================
- Coverage        61.09%   51.01%   -10.08%     
================================================
  Files              126      126               
  Lines            11351    11351               
================================================
- Hits              6935     5791     -1144     
- Misses            3524     4809     +1285     
+ Partials           892      751      -141
Impacted Files Coverage Δ
registry/storage/driver/gcs/gcs.go 0.4% <0%> (-68.94%) ⬇️
registry/storage/driver/oss/oss.go 0.57% <0%> (-57.43%) ⬇️
registry/storage/driver/s3-aws/s3.go 4.17% <0%> (-56.55%) ⬇️
registry/storage/driver/s3-goamz/s3.go 0.5% <0%> (-50.51%) ⬇️
registry/client/transport/transport.go 69.69% <0%> (-9.1%) ⬇️
configuration/configuration.go 68.33% <0%> (-0.27%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a25b9ef...ed2b686. Read the comment docs.

@mdlinville
Copy link
Contributor Author

What does all of that mean? ^

@dmcgowan
Copy link
Collaborator

@mstanleyjones it means we really need to turn off codecov

@dmcgowan
Copy link
Collaborator

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants