Remove redundant map for route hashes#489
Merged
topi314 merged 1 commit intodisgoorg:masterfrom Nov 12, 2025
Merged
Conversation
topi314
approved these changes
Nov 12, 2025
Member
topi314
left a comment
There was a problem hiding this comment.
Fair enough.
There was never more expensive hashing involved tho, it's probably a remnant of me porting this code from somewhere else and them using it
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm guessing this map was added when there was some more expensive hashing for the endpoints involved. Right now the "hash" is just a combination of
endpoint.Endpoint.Methodandendpoint.Endpoint.Route.Locking the mutex and reading from the map must be way more expensive than just computing that every time. Maybe I'm missing something here tho