Skip to content

[FEATURE] Role Subscriptions #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
May 15, 2023
Merged

[FEATURE] Role Subscriptions #136

merged 5 commits into from
May 15, 2023

Conversation

@seailz
Copy link
Member

@seailz seailz commented Feb 13, 2023 •
edited
Loading

Pull Request

  • I have checked the PRs for upcoming features/bug fixes.

Changes

  • Internal code
  • Library
  • Documentation

Closes #130

Description

Adds role subscription support into discord.jar.
Docs PR used for these additions:

Currently waiting on:

@seailz seailz added status: awaiting discord Awaiting a PR on Discord API docs type: feature Issue or PR is a feature that should be implemented priority: low Low priority status: completed status: claimed Issue has a PR open for it. labels Feb 13, 2023
@seailz seailz added this to the discord.jar 1.0 milestone Feb 13, 2023
@seailz seailz self-assigned this Feb 13, 2023
@seailz seailz requested review from blueysh and joeecodes February 13, 2023 18:19
blueysh
blueysh suggested changes Feb 14, 2023
View reviewed changes
Copy link
Member

@blueysh blueysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

just a bit of naming stuff but the rest LGTM

@seailz seailz requested a review from blueysh February 14, 2023 13:46
@seailz seailz removed the request for review from joeecodes February 15, 2023 09:14
@seailz seailz marked this pull request as draft February 21, 2023 17:14
@seailz seailz marked this pull request as ready for review May 7, 2023 20:22
@seailz seailz merged commit f332443 into main May 15, 2023
@seailz seailz deleted the feature/rolesub branch May 15, 2023 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@blueysh blueysh blueysh approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@seailz seailz

Labels

priority: low Low priority status: awaiting discord Awaiting a PR on Discord API docs status: claimed Issue has a PR open for it. status: completed type: feature Issue or PR is a feature that should be implemented

Projects

None yet

Milestone

discord.jar 1.0

Development

Successfully merging this pull request may close these issues.

[Feature Request] Role Subscriptions

3 participants

@seailz @blueysh