Skip to content

reset details scroll when different msg chosen #113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 26, 2025
Merged

reset details scroll when different msg chosen #113

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
da902c5
reset details scroll when different msg chosen
dhth Sep 26, 2025
28117d8
remove redundant check
dhth Sep 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 9 additions & 9 deletions internal/tui/update.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,14 +17,16 @@ const (
func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
var cmd tea.Cmd
var cmds []tea.Cmd
forceRefreshMsgDetailsVP := false
terminalResized := false
m.msg = ""
m.errorMsg = ""

switch msg := msg.(type) {
case tea.WindowSizeMsg:
m.terminalHeight = msg.Height
m.terminalWidth = msg.Width
terminalResized = true

if msg.Width < minWidthNeeded || msg.Height < minHeightNeeded {
if m.activeView != insufficientDimensionsView {
m.lastViewBeforeInsufficientDims = m.activeView
Expand Down Expand Up @@ -168,8 +170,6 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
m.msgsList.CursorDown()
case "j", "down":
switch m.activeView {
case msgListView:
m.msgDetailsVP.GotoTop()
case msgDetailsView:
if m.msgDetailsVP.AtBottom() {
break
Expand All @@ -183,8 +183,6 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
}
case "k", "up":
switch m.activeView {
case msgListView:
m.msgDetailsVP.GotoTop()
case msgDetailsView:
if m.msgDetailsVP.AtTop() {
break
Expand Down Expand Up @@ -266,7 +264,6 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
m.msgDetailsVP.Width = m.msgDetailsVPWidth
m.msgDetailsVP.Height = msgDetailsVPHeight
}
forceRefreshMsgDetailsVP = true

helpVPWidth := msg.Width - w2 - 4
if !m.helpVPReady {
Expand Down Expand Up @@ -334,19 +331,22 @@ func (m Model) Update(msg tea.Msg) (tea.Model, tea.Cmd) {
cmds = append(cmds, cmd)
}

m.updateMsgDetailsVP(forceRefreshMsgDetailsVP)
m.updateMsgDetailsVP(terminalResized)

return m, tea.Batch(cmds...)
}

func (m *Model) updateMsgDetailsVP(forceRefresh bool) {
func (m *Model) updateMsgDetailsVP(terminalResized bool) {
if m.activeView == msgListView || m.activeView == msgDetailsView {
if len(m.msgsList.Items()) > 0 && (forceRefresh || m.msgsList.Index() != m.currentMsgIndex) {
if len(m.msgsList.Items()) > 0 && (terminalResized || m.msgsList.Index() != m.currentMsgIndex) {
m.currentMsgIndex = m.msgsList.Index()
message, ok := m.msgsList.SelectedItem().(t.Message)

if ok {
m.msgDetailsVP.SetContent(getMsgDetailsStylized(message, m.config.Encoding, m.msgDetailsVPWidth))
if !terminalResized {
m.msgDetailsVP.GotoTop()
}
}

}
Expand Down