fix: quit help pane when ? is pressed #111
Conversation
Summary of ChangesHello @dhth, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly improves the user experience of the terminal user interface (TUI) by introducing more intuitive navigation controls. The primary changes include making the help pane a toggleable feature and adding several new keybindings for efficient scrolling and movement within different application views. These enhancements aim to streamline interaction and make information more accessible. Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request aims to allow quitting the help pane by pressing ?, effectively making it a toggle. The implementation for this is correct. However, my review found that this change interacts with a pre-existing critical bug in view-switching logic that can cause the application to become stuck in the help view under certain conditions.
Additionally, this PR introduces several new keybindings for navigation (g, G, ctrl+d, ctrl+u). While these are useful features, they are unrelated to the stated purpose of the PR and should ideally be submitted in a separate pull request to maintain a clean and focused commit history. I've also provided feedback on a minor inconsistency with the new ctrl+u binding.
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request introduces two main changes. First, it fixes a bug where the previous view state could be lost when the terminal is resized to be too small while the help pane is active. This is solved by adding a new lastViewBeforeInsufficientDims field to the model. Second, it changes the behavior of the ? key to act as a toggle for the help pane, improving user experience. The changes are logical and correct. I've added one suggestion to consider a more scalable view management approach using a stack, which could simplify the state management in the long run.
No description provided.