Skip to content

Conversation

sghng
Copy link

@sghng sghng commented Oct 3, 2025

Double check these details before you open a PR

  • PR does not match another non-stale PR currently opened
  • PR name matches the format new icon: Icon name (versions separated by comma). More details here
  • PR's base is the develop branch.
  • Your icons are inside a folder as seen here
  • SVG matches the standards laid out here
  • A new object is added in the devicon.json file at the correct alphabetic position as seen here

This PR closes NONE

Link to prove your SVG is correct and up-to-date.

From fish-shell/fish-shell#11825 (comment)

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sghng,

thank you for your contribution. I have found some things we need to change before merging the icon. Please let me know if you need more infos or explanations.

Cheers Patrik

@sghng
Copy link
Author

sghng commented Oct 7, 2025

@weh thanks for the review! I have updated the svgs and did the optimization. I noticed that in the wiki it requires the "most prominent color" from original to be used as the color for plain svg, however, what if the brand theme is a different color? In my case, I picked blue as it seems to be the primary color on the Fish website.

@sghng sghng changed the title new icon: fish (original) new icon: fish (original, plain) Oct 7, 2025
@sghng
Copy link
Author

sghng commented Oct 7, 2025

plain svg just pushed (somehow forgot it)

@weh
Copy link
Contributor

weh commented Oct 7, 2025

plain svg just pushed (somehow forgot it)

i was just writing that the file is missing when you updated the branch.
However, i missed a last small thing. The filenames should be fish-original.svg and fish-plain.svg.
Sorry i did miss that in the initial review 😊

Copy link
Contributor

@weh weh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice work @sghng, blue is ok IMHO, can still be changed easy if needed.

@weh weh added bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger bot:check Trigger check-bot. Remove and re-add the label to re-trigger labels Oct 7, 2025
@weh weh requested review from a team, ConX, ReenigneArcher, Snailedlt, canaleal and lunatic-fox and removed request for a team October 7, 2025 18:57
@weh weh added the hacktoberfest-accepted Accepted to be counted towards Hacktoberfest label Oct 7, 2025
Copy link
Contributor

github-actions bot commented Oct 7, 2025

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:
Imgur Images

Here are the zoomed-in screenshots of the added icons as SVGs:
Imgur Images

Here are the icons that will be generated by Icomoon:
Imgur Images

Here are the zoomed-in screenshots of the added icons as icons:
Imgur Images

Here are the colored versions:
Imgur Images

The maintainers will now check for:

  1. The number of Glyphs matches the number of SVGs that were selected.
  2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
  3. The icons are of high quality (legible, matches the official logo, etc.)
  4. A new object is added in the devicon.json file at the correct alphabetic position as seen here

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊

@weh weh added the feature:icon PR when a new icon is ready to be added to the collection label Oct 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bot:check Trigger check-bot. Remove and re-add the label to re-trigger bot:peek Trigger peek-bot. Remove and re-add the label to re-trigger feature:icon PR when a new icon is ready to be added to the collection hacktoberfest-accepted Accepted to be counted towards Hacktoberfest

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants