-
Notifications
You must be signed in to change notification settings - Fork 2.4k
new icon: fish (original, plain) #2565
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: develop
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @sghng,
thank you for your contribution. I have found some things we need to change before merging the icon. Please let me know if you need more infos or explanations.
Cheers Patrik
@weh thanks for the review! I have updated the svgs and did the optimization. I noticed that in the wiki it requires the "most prominent color" from original to be used as the color for plain svg, however, what if the brand theme is a different color? In my case, I picked blue as it seems to be the primary color on the Fish website. |
plain svg just pushed (somehow forgot it) |
i was just writing that the file is missing when you updated the branch. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice work @sghng, blue is ok IMHO, can still be changed easy if needed.
Hi there, I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io. Here are the SVGs as intepreted by Icomoon when we upload the files: Here are the zoomed-in screenshots of the added icons as SVGs: Here are the icons that will be generated by Icomoon: Here are the zoomed-in screenshots of the added icons as icons: Here are the colored versions: The maintainers will now check for:
In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done. Thank you for contributing to Devicon! I hope that your icons are accepted into the repository. Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice. Cheers, |
Double check these details before you open a PR
develop
branch.devicon.json
file at the correct alphabetic position as seen hereThis PR closes NONE
Link to prove your SVG is correct and up-to-date.
From fish-shell/fish-shell#11825 (comment)