looks pretty good, but the viewbox is not 128x128. Also i am not sure if all the xml attributes are needed. Please fix the viewbox :)

@weh
thank you very much for taking the time to review my pr and for the feedback :)
I was in the middle of moving so havent used my computer in a while.
I'm in the process of clearing useless xml attributes.
I do have a question about the viewbox, it seems to indeed be 128x128 for the 3 files, would you mind letting me know if i am missing something ? it's my first time doing something like that so it might just be me.
i can make the viewbox smaller by adjusting it to the content if that is prefered.
thanks again !

you are right, the viewBox size is indeed 128x128, but it has a offset of 663.38 and 37.570
i had this just recently so i can tell you how to fix it.

First thing i would do, is to make sure all elements are in a group. This makes it easier to move all elements together.
so ctrl + A and ctrl + G should do that.

Next step is to set the X and Y offset of the viewbox to 0.
This will move the logo out of the visible viewbox, and you will have to zoom out to see it.

Then you can follow the Steps 5 and 6 in this tutorial

• https://github.com/devicons/devicon/wiki/Creating-original-Icons#step-5-center-the-group
• https://github.com/devicons/devicon/wiki/Creating-original-Icons#step-6-ungroup-all-paths

There are some Tutorials in the Wiki, and you can always ask if you need help.
I think there is also a list of SVOMG options that should be enabled/disabled to optimize the images.

@weh

Thanks again for the help, following your hints i went back to the drawing board and fixed the icons viewboxes and htlm attributes (i deleted the attributes i knew wouldnt break the file, im learning on the fly tho)
It should be better now !

edit : i also rectified the icon files names since i just realized they weren't correct

Hi there,

I'm Devicons' Peek Bot and I just peeked at the icons that you wanted to add using icomoon.io.

Here are the SVGs as intepreted by Icomoon when we upload the files:

Here are the zoomed-in screenshots of the added icons as SVGs:

Here are the icons that will be generated by Icomoon:

Here are the zoomed-in screenshots of the added icons as icons:

Here are the colored versions:

The maintainers will now check for:

1. The number of Glyphs matches the number of SVGs that were selected.
2. The icons (second group of pictures) look the same as the SVGs (first group of pictures).
3. The icons are of high quality (legible, matches the official logo, etc.)
4. A new object is added in the devicon.json file at the correct alphabetic position as seen here

In case of font issues, it might be caused by Icomoon not accepting strokes in the SVGs. Check this doc for more details and fix the issues as instructed by Icomoon and update this PR once you are done.

Thank you for contributing to Devicon! I hope that your icons are accepted into the repository.

Note: If the images don't show up, it has been autodeleted by Imgur after 6 months due to our API choice.

Cheers,
Peek Bot 😊