-
Notifications
You must be signed in to change notification settings - Fork 0
Hjiang/load table #69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Summary of Changes
Hello @dentiny, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a new batch ingestion capability for the mooncake_table
, allowing for efficient loading of data directly from Parquet files. This enhancement streamlines the process of populating tables with pre-existing data, complementing the existing streaming transaction mechanisms. It involves adding a new module for batch ingestion, integrating it into the table event handling system, and updating dependencies and test infrastructure to support this new functionality.
Highlights
- Batch Ingestion Functionality: A new asynchronous function,
batch_ingest
, has been added to theMooncakeTable
struct. This function is responsible for efficiently loading data from a list of specified Parquet files into the table. - New Table Event for Bulk Loading: A new event type,
TableEvent::LoadFiles
, has been introduced. This event carries the paths to Parquet files and a Logical Sequence Number (LSN), allowing external systems to trigger the batch ingestion process. - Integration with Table Event Handler: The
TableHandler
has been updated to recognize and process theTableEvent::LoadFiles
. Upon receiving this event, it dispatches the files to theMooncakeTable
's newbatch_ingest
method. - Dependency Addition (bytes crate): The
bytes
crate has been added as a dependency across relevantCargo.toml
files. This crate provides efficient byte buffers, which are crucial for handling the content of Parquet files during the ingestion process. - Enhanced Testing Utilities and New Test Case: New test utilities,
bulk_upload_files
andgenerate_parquet_file
, have been added to simplify the creation of test scenarios for batch ingestion. A dedicated test case,test_batch_ingestion
, has also been implemented to validate the end-to-end bulk loading process. - Transaction Stream Modifications: The
commit_lsn
field withinTransactionStreamState
has been made publicly accessible within the crate (pub(crate)
), and a new constructorfrom_disk_files
has been added toTransactionStreamCommit
to support the new ingestion workflow.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command>
or @gemini-code-assist <command>
. Below is a summary of the supported commands.
Feature | Command | Description |
---|---|---|
Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/
folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
Warning Gemini encountered an error creating the review. You can try again by commenting |
Summary
Briefly explain what this PR does.
Related Issues
Closes # or links to related issues.
Changes
Checklist