Skip to content

fix(*): build and run the server inside alpine:3.3 (WIP) #50

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
arschles wants to merge 4 commits into from
Closed

fix(*): build and run the server inside alpine:3.3 (WIP) #50

arschles wants to merge 4 commits into from

Conversation

@arschles
Copy link
Member

@arschles arschles commented Jan 15, 2016

Fixes #8

@arschles arschles self-assigned this Jan 15, 2016
@arschles arschles added this to the v2.0-beta1 milestone Jan 15, 2016
@mboersma mboersma added the LGTM1 label Jan 15, 2016
@arschles
Copy link
Member Author

arschles commented Jan 26, 2016

this is untested in production

Aaron Schlesinger added 4 commits February 4, 2016 16:46
fix(Makefile): remove docker-build dependency in docker-push
f0a93a4
fix(Dockerfile): convert minio server dockerfile to be based on alpine
ce8d1a5
fix(install.sh): build minio server as static binary
319721b 
can’t turn off CGO, but this is enough to get a minio server binary
that can run in alpine, as long as DOCKERIMAGE is set to 1 in the
environment in which it runs
fix(Makefile,server/install.sh): use the minio makefile target
e730b51 
instead of manually building with ‘go build’
@arschles
Copy link
Member Author

arschles commented Feb 5, 2016

removing both LGTMs - current status of this PR is that the minio server fails to start with sh: minio: not found

@arschles arschles changed the title fix(*): build and run the server inside alpine:3.3 fix(*): build and run the server inside alpine:3.3 (WIP) Feb 5, 2016
@arschles arschles removed this from the v2.0-beta1 milestone Feb 19, 2016
@arschles
Copy link
Member Author

arschles commented Feb 19, 2016

removing the v2-beta milestone since this isn't critical for the release

@mboersma
Copy link
Member

mboersma commented May 23, 2016

Just to note: deis/minio currently builds minio from source using commit SHA 356b889. When we previously had tried to move to an official release tag, we saw problems in testing and reverted. This was months ago, so it's probably worth revisiting updated minio releases and/or binary builds.

@arschles
Copy link
Member Author

arschles commented May 23, 2016

@mboersma thanks for the context. I'm putting this on the v2 milestone so we can try again, and I'll rebase now

@arschles
Copy link
Member Author

arschles commented May 23, 2016

Oops, actually this PR is obsoleted by #98, which has moved minio to run in ubuntu-slim. Closing.

Also, using binary builds is tracked in #87

@arschles arschles closed this May 23, 2016
@arschles arschles deleted the alpine-server branch May 23, 2016 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@arschles arschles

Labels

enhancement needs rebase

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@arschles @mboersma @bacongobbler