Skip to content

Allow exit/quit to work when not connected to a database. #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 4, 2018
Merged

Allow exit/quit to work when not connected to a database. #29

merged 1 commit into from
Dec 4, 2018

Conversation

amjith
Copy link
Member

@amjith amjith commented Dec 3, 2018

Fixes #28

@amjith amjith requested a review from delgermurun December 3, 2018 01:58
@codecov-io
Copy link

Codecov Report

❗ No coverage uploaded for pull request base (master@ae21b70). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage          ?   59.83%           
=========================================
  Files             ?       22           
  Lines             ?     1347           
  Branches          ?        0           
=========================================
  Hits              ?      806           
  Misses            ?      541           
  Partials          ?        0
Impacted Files Coverage Δ
litecli/sqlexecute.py 60.52% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae21b70...079400e. Read the comment docs.

1 similar comment
@codecov-io
Copy link

codecov-io commented Dec 3, 2018 •
edited
Loading

Codecov Report

❗ No coverage uploaded for pull request base (master@ae21b70). Click here to learn what that means.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             master      #29   +/-   ##
=========================================
  Coverage          ?   59.83%           
=========================================
  Files             ?       22           
  Lines             ?     1347           
  Branches          ?        0           
=========================================
  Hits              ?      806           
  Misses            ?      541           
  Partials          ?        0
Impacted Files Coverage Δ
litecli/sqlexecute.py 60.52% <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ae21b70...079400e. Read the comment docs.

@delgermurun delgermurun merged commit 079400e into master Dec 4, 2018
@delgermurun delgermurun deleted the exit-nodb branch December 4, 2018 10:02
delgermurun
delgermurun reviewed Dec 4, 2018
View reviewed changes
Copy link
Member

@delgermurun delgermurun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

works. Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@delgermurun delgermurun delgermurun left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@amjith @codecov-io @delgermurun