Skip to content

Conversation

@gerhard
Copy link
Contributor

@gerhard gerhard commented Mar 9, 2022

We assume that this will be out by then.

The latest version is v1 (v1.2.1 specifically). Since we cannot undo the versioning, and go back to v0.2, we capture the breaking change in with properties, and the new version default value (0.2/latest after #1733) and go to the next version that we can: v2

cc @crazy-max @grouville

@netlify
Copy link

netlify bot commented Mar 9, 2022

✔️ Deploy Preview for devel-docs-dagger-io ready!

🔨 Explore the source changes: 74c3465

🔍 Inspect the deploy log: https://app.netlify.com/sites/devel-docs-dagger-io/deploys/6229190e00c35a000826478f

😎 Browse the preview: https://deploy-preview-1734--devel-docs-dagger-io.netlify.app

@gerhard
Copy link
Contributor Author

gerhard commented Mar 9, 2022

@aluzzardi do you think that we should keep this syntax for the new GitHub Action, or go back to args?

      - name: Deploy to Netlify
        # https://github.com/dagger/dagger-for-github
        uses: dagger/dagger-for-github@v2
        with:
          workdir: pkg/universe.dagger.io/examples/todoapp
          plan: .
          do: deploy

I don't mind either way as long as we end up with the accurate version in the docs.

@aluzzardi
Copy link
Contributor

Let's keep it as args.

The interface is still changing (e.g. we might decide that -p means plan, or project, or potato), I say we use args now and add a nice layer on top (do, plan, ...) once the interface is stabilized.

We assume that this will be out by the time this goes live.

Signed-off-by: Gerhard Lazu <[email protected]>
@gerhard
Copy link
Contributor Author

gerhard commented Mar 9, 2022

OK, all the above makes sense @aluzzardi.
Is dagger/dagger-for-github@v1 going to default to Europa when it become available?
If not, should we set the dagger version to 0.2 explicitly?

@aluzzardi
Copy link
Contributor

We want to keep dagger/dagger-for-github@v1 to 0.1 and dagger/dagger-for-github@v2 to latest (just like we changed this morning in the repo)

@gerhard
Copy link
Contributor Author

gerhard commented Mar 9, 2022

Yes, that is my understanding as well, just double-checking with you.

@gerhard
Copy link
Contributor Author

gerhard commented Mar 9, 2022

We are in agreement, I am merging as is and assuming that dagger/dagger-for-github@v2 will be tagged & made available so that this works as advertised.

@gerhard gerhard merged commit 4e869d1 into dagger:main Mar 9, 2022
@gerhard gerhard deleted the github-action-version-fix branch March 9, 2022 21:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants