Skip to content

Conversation

dubo-dubon-duponey
Copy link
Contributor

Since src and dest are mandatory (and already provide defaults), this seem to make more sense to not mark them as optional in the schema.

This will fix #9

Signed-off-by: dubo-dubon-duponey <[email protected]>
@aluzzardi aluzzardi merged commit 1d2d3db into dagger:main Jan 12, 2021
@aluzzardi aluzzardi deleted the fix-9 branch January 12, 2021 01:54
vikram-dagger pushed a commit to vikram-dagger/dagger that referenced this pull request Aug 24, 2023
gerhard pushed a commit that referenced this pull request Sep 18, 2023
)

package jar with dependencies and upload artifact in github
upload artifact only on push to main
update README.md
---------

Signed-off-by: Jean-Christophe Sirot <[email protected]>
gerhard added a commit that referenced this pull request Sep 18, 2023
* Initial commit

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* Initial version (#1)

Initial version of the SDK
---------

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* Clean up build process & better samples (#2)

* build: clean up build

update pom.xml dependency management
remove unused dependencies
remove unused import

* build: Add maven exec plugin to run the code samples from the CLI

* build: support dependency caching in github action (#3)

* fix: add missing sample in the sample code demo app (#4)

* feat(log): add debug log when response is contains errors. (#5)

Set the log level to debug in integration tests

* fix: support macos arm64 architure by cli downloader (#7)

* fix: client hangs on close (#8)

fix(connection): refactoring of the engine connection package

Move CLIRunner and ConnectParams to a dedicated class file
Replace JSON-B by JSON-P to deserialize the connection parameters
Move the Dagger CLI process execution to the CLI runner (Single-responsibility principle)
Fix process hanging when connection to the engine failed
Improve code style
Add some tests for Connection class

---------

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* build(workflow): enable build on linux and macos (#9)

macos is limited to PR builds
So far windows VM does not support Linux containers

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* build: package jar with dependencies and upload artifacts in github (#11)

package jar with dependencies and upload artifact in github
upload artifact only on push to main
update README.md
---------

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* Move all files into sdk/java subdir

So that this can be imported into dagger/dagger repository

Signed-off-by: Gerhard Lazu <[email protected]>

* sdk(java): Add experimental warning to README

Signed-off-by: Gerhard Lazu <[email protected]>

* sdk(java): Rename LICENSE

But keep as is, same as we did for other experimental SDKs.

Signed-off-by: Gerhard Lazu <[email protected]>

* chore: Add /sdk/java to CODEOWNERS

Signed-off-by: Gerhard Lazu <[email protected]>

* build: rename package name from 'org.chelonix.dagger.*' to 'io.dagger.*'

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* build(codegen): add introspection query in the codegen plugin resources and use it when schema is not available. Inject the CLI version in the code at build time

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* build: add linter plugin and lint current code

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* build: set development version to 1.0.0-SNAPSHOT. Add "release" profile dedicated to deployment

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* fix: correctly return the dagger CLI path in codegen plugin and fix some log messages

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* build: Add schema for 0.6.4

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* fix: fix coding style for linter

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* build: fix maven versions plugin groupId

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* ci: add java sdk CI
- add initial build worflow in internal/mage/sdk/java.go
- add test & lint actions in github action worflow

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* fix: replace deprecated API calls in tests
- Container.fs -> Container.rootfs
- Container.exec -> Container.withExec

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* fix: Add a static 'from' method to instanciate a Scalar from a String literal

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* fix(doc): fix javadoc for field parameters in generated code

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* fix: Fix NPE when CLI download fails and log error

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* fix(codegen): clarify codegen plugin parameters and Dagger version in generated code

Separate CLI and SDK version
Use either a previously generated schema or a query a locally installed dagger CLI
update the CI to generate the schema matching the used dagger CLI

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* fix(codegen): fix sdk:java:generate goal

Now the generate goal will query the dagger CLI to generate the API JSON schema and write a file
A new dagger-codegen:generateSchema plugin goal has been added to the  dagger-codegen maven plugin (with some code refactoring between both goals) to generate the schema. The generate schema is copied to plugin resources dir /schemas according to the engine version declared in the pom.xml file afterwards.
The schema file naming has been simplifying (removing the 'v' prefix) and the existing files have been renamed accordingly

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* feat(codegen): add schema for dagger engine 0.8.3 and 0.8.4

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* doc(codegen): document how to bump engine dependency

Signed-off-by: Jean-Christophe Sirot <[email protected]>

* Remove redundant return & go fmt

Signed-off-by: Gerhard Lazu <[email protected]>

* Make Java SDK workflow standalone, same as the Elixir one

Leverage the re-usable _hack_make workflow.

Signed-off-by: Gerhard Lazu <[email protected]>

* Use same Apache 2.0 license as all other SDKs

Engine & CLI use the same Apache 2.0 license.

Signed-off-by: Jean-Christophe Sirot <[email protected]>

---------

Signed-off-by: Jean-Christophe Sirot <[email protected]>
Signed-off-by: Jean-Christophe Sirot <[email protected]>
Signed-off-by: Gerhard Lazu <[email protected]>
Signed-off-by: Jean-Christophe Sirot <[email protected]>
Co-authored-by: Jean-Christophe Sirot <[email protected]>
Co-authored-by: Jean-Christophe Sirot <[email protected]>
Co-authored-by: Daniel Lavoie <[email protected]>
vikram-dagger pushed a commit to vikram-dagger/dagger that referenced this pull request Aug 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

#Copy marks src as optional, but it is not, and should default to the schema default

2 participants