feat: service category label for platform containers & hide containers based on category #807
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportPatch coverage:
❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the GitHub App Integration for your organization. Read more. Additional details and impacted files@@ Coverage Diff @@
## develop #807 +/- ##
========================================
Coverage 24.13% 24.13%
========================================
Files 62 62
Lines 5954 5958 +4
========================================
+ Hits 1437 1438 +1
- Misses 4411 4414 +3
Partials 106 106
☔ View full report in Codecov by Sentry. |
Collaborator
|
Please add new labels to docker compose and CLI containers. |
m8vago
approved these changes
Sep 1, 2023
polaroi8d
requested changes
Sep 4, 2023
Collaborator
polaroi8d
left a comment
There was a problem hiding this comment.
TypeError: Cannot read properties of undefined (reading 'org.dyrectorio.service-category')
chandhuDev
pushed a commit
to chandhuDev/dyrectorio
that referenced
this pull request
Nov 7, 2023
…s based on category (dyrector-io#807)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
org.dyrectorio.service-category=_internallabels to all platform containers.labelsto agent container proto.kube-system.