feat(web): protected deployment #781
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
140a732 to
fce0cb9
Compare
polaroi8d
approved these changes
Aug 16, 2023
Collaborator
polaroi8d
left a comment
There was a problem hiding this comment.
Tested, works like a charm 🤩
m8vago
requested changes
Aug 16, 2023
web/crux-ui/src/components/projects/versions/deployments/add-deployment-card.tsx
Show resolved
Hide resolved
web/crux/src/app/deploy/interceptors/deploy.start.interceptor.ts
Outdated
Show resolved
Hide resolved
web/crux/src/app/deploy/interceptors/deploy.start.interceptor.ts
Outdated
Show resolved
Hide resolved
m8vago
approved these changes
Aug 18, 2023
Contributor
m8vago
left a comment
There was a problem hiding this comment.
Just some minor inconvenience in ifs. We can fix that in a later pr.
web/crux/src/app/deploy/interceptors/deploy.create.interceptor.ts
Outdated
Show resolved
Hide resolved
web/crux/src/app/deploy/interceptors/deploy.patch.interceptor.ts
Outdated
Show resolved
Hide resolved
web/crux/src/app/deploy/interceptors/deploy.start.interceptor.ts
Outdated
Show resolved
Hide resolved
web/crux/src/app/deploy/interceptors/deploy.start.interceptor.ts
Outdated
Show resolved
Hide resolved
m8vago
approved these changes
Aug 18, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
startDeploylogic to a custom hook