Skip to content

Conversation

@robot9706
Copy link
Contributor

@robot9706 robot9706 commented Aug 3, 2023

  • Added METRICS_API_PORT env which hosts /api/metrics.
  • Added ws_connected_clients, ws_route_namespaces{path=...}, ws_message_type_receive{type=..} and ws_message_type_send{type=...} WebSocket metrics.
  • Added registry_type_count{type=...}, registry_hub_cache{type=[hit/miss]}, registry_api_request{type=..., request=[catalog/tags]} registry metrics.

@robot9706 robot9706 self-assigned this Aug 3, 2023
@github-actions github-actions bot added pr:feat source:web The scope of the issue or pull request is web. lang:typescript and removed pr:feat labels Aug 3, 2023
@robot9706 robot9706 force-pushed the feat/metric-api branch 3 times, most recently from 10378a4 to 75cbefa Compare August 4, 2023 13:13
@robot9706 robot9706 marked this pull request as ready for review August 4, 2023 13:42
@robot9706 robot9706 requested a review from a team as a code owner August 4, 2023 13:42
Copy link
Contributor

@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@polaroi8d
Copy link
Collaborator

Please don't forget to resolve conflicts.

Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@robot9706 robot9706 requested a review from m8vago August 10, 2023 12:50
@robot9706 robot9706 merged commit 7b0debc into develop Aug 11, 2023
@robot9706 robot9706 deleted the feat/metric-api branch August 11, 2023 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lang:typescript pr:feat severity:medium source:web The scope of the issue or pull request is web.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants