Skip to content

refactor(crane): use deployment, add RBAC changes #775

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Aug 2, 2023
Merged

refactor(crane): use deployment, add RBAC changes #775

merged 2 commits into from
Aug 2, 2023

Conversation

@nandor-magyar
Copy link
Contributor

@nandor-magyar nandor-magyar commented Aug 1, 2023

Launching crane as a pod proved to be wrong, reverting to deployment.

@nandor-magyar nandor-magyar requested a review from a team as a code owner August 1, 2023 11:14
@github-actions github-actions bot added pr:refactor source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web. lang:golang lang:shell and removed pr:refactor labels Aug 1, 2023
@nandor-magyar nandor-magyar force-pushed the refactor/crane-deployment branch from 9cc9e3d to 568fbd9 Compare August 1, 2023 11:15
@nandor-magyar nandor-magyar force-pushed the refactor/crane-deployment branch 2 times, most recently from 0f88f26 to e1f3474 Compare August 1, 2023 11:19
robot9706
robot9706 reviewed Aug 1, 2023
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Aug 1, 2023 •
edited
Loading

Codecov Report

Patch coverage has no change and project coverage change: -0.06% ⚠️

Comparison is base (fca04ff) 25.60% compared to head (a4bef87) 25.54%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #775      +/-   ##
===========================================
- Coverage    25.60%   25.54%   -0.06%     
===========================================
  Files           60       60              
  Lines         5690     5703      +13     
===========================================
  Hits          1457     1457              
- Misses        4132     4145      +13     
  Partials       101      101
Files Changed Coverage Δ
golang/internal/health/server.go 0.00% <0.00%> (ø)
golang/internal/health/types.go 0.00% <0.00%> (ø)
golang/pkg/crane/k8s/namespace.go 0.00% <0.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nandor-magyar nandor-magyar force-pushed the refactor/crane-deployment branch 2 times, most recently from eb3315f to 2bd64a7 Compare August 1, 2023 11:48
polaroi8d
polaroi8d reviewed Aug 2, 2023
View reviewed changes
@nandor-magyar nandor-magyar force-pushed the refactor/crane-deployment branch from 1d763b3 to c770c36 Compare August 2, 2023 09:42
@nandor-magyar nandor-magyar force-pushed the refactor/crane-deployment branch from c770c36 to a4bef87 Compare August 2, 2023 12:04
@m8vago m8vago merged commit 87f90fa into develop Aug 2, 2023
@m8vago m8vago deleted the refactor/crane-deployment branch August 2, 2023 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polaroi8d polaroi8d polaroi8d left review comments

@robot9706 robot9706 robot9706 approved these changes

Assignees

@nandor-magyar nandor-magyar

Labels

lang:golang lang:shell pr:refactor source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@nandor-magyar @codecov-commenter @robot9706 @polaroi8d @m8vago