Skip to content

fix(web): config validation & project version number & dagent correct image log #764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 25, 2023
Merged

fix(web): config validation & project version number & dagent correct image log #764

merged 12 commits into from
Jul 25, 2023

Conversation

@robot9706
Copy link
Contributor

@robot9706 robot9706 commented Jul 25, 2023 •
edited
Loading

  • Swapped internal and external port inputs.
  • Fixed port validation showing 'NaN' is invalid, instead shows 'value is required'.
  • Added port validation error to crane health check port input.
  • Fixed icon picker buttons not circles.
  • Fixed project version count missing from list view.
  • Fixed dagent showing docker.io/... when using a local image.
  • Fixed copying a deployment does not copy the shared environment

@robot9706 robot9706 requested a review from a team as a code owner July 25, 2023 09:45
@robot9706 robot9706 self-assigned this Jul 25, 2023
@github-actions github-actions bot added source:web The scope of the issue or pull request is web. lang:typescript labels Jul 25, 2023
@robot9706 robot9706 changed the title Fix/config projects fix(web): config validation & project version number Jul 25, 2023
@robot9706 robot9706 changed the title fix(web): config validation & project version number fix(web): config validation & project version number & dagent correct image log Jul 25, 2023
@github-actions github-actions bot added source:agent The scope of the issue or pull request is agent. lang:golang labels Jul 25, 2023
@codecov-commenter
Copy link

codecov-commenter commented Jul 25, 2023 •
edited
Loading

Codecov Report

Patch coverage: 8.33% and project coverage change: -0.02% ⚠️

Comparison is base (af37049) 25.89% compared to head (5ebb39e) 25.88%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

Additional details and impacted files 
@@             Coverage Diff             @@
##           develop     #764      +/-   ##
===========================================
- Coverage    25.89%   25.88%   -0.02%     
===========================================
  Files           56       56              
  Lines         5560     5567       +7     
===========================================
+ Hits          1440     1441       +1     
- Misses        4022     4028       +6     
  Partials        98       98
Files Changed Coverage Δ
golang/pkg/dagent/utils/docker.go 3.16% <0.00%> (-0.04%) ⬇️
golang/internal/mapper/grpc.go 65.83% <100.00%> (+0.07%) ⬆️

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nandor-magyar
nandor-magyar approved these changes Jul 25, 2023
View reviewed changes
Copy link
Contributor

@nandor-magyar nandor-magyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

polaroi8d
polaroi8d approved these changes Jul 25, 2023
View reviewed changes
Copy link
Collaborator

@polaroi8d polaroi8d left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nandor-magyar nandor-magyar merged commit 6e531d5 into develop Jul 25, 2023
@nandor-magyar nandor-magyar deleted the fix/config-projects branch July 25, 2023 15:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@polaroi8d polaroi8d polaroi8d approved these changes

@nandor-magyar nandor-magyar nandor-magyar approved these changes

Assignees

@robot9706 robot9706

Labels

lang:golang lang:typescript pr:fix severity:medium source:agent The scope of the issue or pull request is agent. source:web The scope of the issue or pull request is web.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@robot9706 @codecov-commenter @polaroi8d @nandor-magyar